From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPaNS-00030V-V6 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:22:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPaNQ-0003NW-Oe for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:22:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPaNQ-0003NJ-GE for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:22:28 -0400 From: Juan Quintela In-Reply-To: <51642C0C.6010607@redhat.com> (Paolo Bonzini's message of "Tue, 09 Apr 2013 16:56:12 +0200") References: <1365511954-10606-1-git-send-email-pbonzini@redhat.com> <8738uzet89.fsf@blackfin.pond.sub.org> <51642C0C.6010607@redhat.com> Date: Tue, 09 Apr 2013 17:22:31 +0200 Message-ID: <87a9p7bufc.fsf@elfo.elfo> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2] migration: initialize RAM to zero Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, aliguori@us.ibm.com, pl@kamp.de, Markus Armbruster , qemu-devel@nongnu.org, owasserm@redhat.com, stefanha@redhat.com Paolo Bonzini wrote: > Il 09/04/2013 15:20, Markus Armbruster ha scritto: >>> > -#if defined(CONFIG_VALGRIND) >>> > - if (running_on_valgrind < 0) { >>> > - /* First call, test whether we are running on Valgrind. >>> > - This is a substitute for RUNNING_ON_VALGRIND from valgrind.h. */ >>> > - const char *ld = getenv("LD_PRELOAD"); >>> > - running_on_valgrind = (ld != NULL && strstr(ld, "vgpreload")); >>> > + if ((intptr_t) ptr == -1) { >> Recommend ptr == MAP_FAILED >> > > Worth respinning? Do it, and put the: Reviewed-by: Juan Quintela