From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIIkf-0003cu-Kb for qemu-devel@nongnu.org; Wed, 20 Mar 2013 09:08:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIIkd-0001PN-U7 for qemu-devel@nongnu.org; Wed, 20 Mar 2013 09:08:21 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:55867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIIkd-0001P9-9O for qemu-devel@nongnu.org; Wed, 20 Mar 2013 09:08:19 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Mar 2013 22:57:54 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 2826C2CE8051 for ; Thu, 21 Mar 2013 00:08:14 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2KCtBm97733720 for ; Wed, 20 Mar 2013 23:55:12 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2KD8DsU023450 for ; Thu, 21 Mar 2013 00:08:13 +1100 From: Anthony Liguori In-Reply-To: <1363773314-32332-2-git-send-email-alevy@redhat.com> References: <1363773314-32332-1-git-send-email-alevy@redhat.com> <1363773314-32332-2-git-send-email-alevy@redhat.com> Date: Wed, 20 Mar 2013 08:08:04 -0500 Message-ID: <87a9py6wy3.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, hdegoede@redhat.com, kraxel@redhat.com Alon Levy writes: > Signed-off-by: Alon Levy > --- > include/char/char.h | 12 ++++++++++++ > qemu-char.c | 7 +++++++ > 2 files changed, 19 insertions(+) > > diff --git a/include/char/char.h b/include/char/char.h > index 0326b2a..0fdcaf9 100644 > --- a/include/char/char.h > +++ b/include/char/char.h > @@ -70,6 +70,7 @@ struct CharDriverState { > void (*chr_set_echo)(struct CharDriverState *chr, bool echo); > void (*chr_guest_open)(struct CharDriverState *chr); > void (*chr_guest_close)(struct CharDriverState *chr); > + void (*chr_post_load)(struct CharDriverState *chr, int > connected); The character device layer should *not* be messing around with notifying migration state. I thought we previously discussed this? Just implement a migration hook in the spice code. Regards, Anthony Liguori > void *opaque; > int idle_tag; > char *label; > @@ -144,6 +145,17 @@ void qemu_chr_fe_open(struct CharDriverState *chr); > void qemu_chr_fe_close(struct CharDriverState *chr); > > /** > + * @qemu_chr_fe_post_load: > + * > + * Indicate to backend that a migration has just completed. Must be called when > + * the vm is in the running state. > + * > + * @connected true if frontend is still connected after migration, false > + * otherwise. > + */ > +void qemu_chr_fe_post_load(struct CharDriverState *chr, int connected); > + > +/** > * @qemu_chr_fe_printf: > * > * Write to a character backend using a printf style interface. > diff --git a/qemu-char.c b/qemu-char.c > index 4e011df..42c911f 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -3390,6 +3390,13 @@ void qemu_chr_fe_open(struct CharDriverState *chr) > } > } > > +void qemu_chr_fe_post_load(struct CharDriverState *chr, int connected) > +{ > + if (chr->chr_post_load) { > + chr->chr_post_load(chr, connected); > + } > +} > + > void qemu_chr_fe_close(struct CharDriverState *chr) > { > if (chr->chr_guest_close) { > -- > 1.8.1.4