From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDeXs-0007cG-5j for qemu-devel@nongnu.org; Thu, 07 Mar 2013 12:23:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDeXn-0001lD-9L for qemu-devel@nongnu.org; Thu, 07 Mar 2013 12:23:56 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:55280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDeXm-0001kq-OD for qemu-devel@nongnu.org; Thu, 07 Mar 2013 12:23:51 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Mar 2013 03:16:08 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id F32333578050 for ; Fri, 8 Mar 2013 04:23:42 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r27HB4wP38141984 for ; Fri, 8 Mar 2013 04:11:05 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r27HNfr9026478 for ; Fri, 8 Mar 2013 04:23:41 +1100 From: Anthony Liguori In-Reply-To: <20130307164938.GA29702@redhat.com> References: <1360108037-9211-1-git-send-email-jlarrew@linux.vnet.ibm.com> <1360108037-9211-3-git-send-email-jlarrew@linux.vnet.ibm.com> <513621F7.9030403@suse.de> <51362575.2000908@de.ibm.com> <87621319kc.fsf@codemonkey.ws> <5138C007.6080305@de.ibm.com> <5138C26B.5010408@suse.de> <87txon6ty5.fsf@codemonkey.ws> <20130307164938.GA29702@redhat.com> Date: Thu, 07 Mar 2013 11:23:31 -0600 Message-ID: <87a9qfunsc.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Stefan Hajnoczi , Jesse Larrew , Alexander Graf , qemu-devel@nongnu.org, Christian Borntraeger , Jens Freimann , Cornelia Huck , Andreas =?utf-8?Q?F=C3=A4rber?= "Michael S. Tsirkin" writes: > On Thu, Mar 07, 2013 at 10:44:18AM -0600, Anthony Liguori wrote: >> Andreas F=C3=A4rber writes: >>=20 >> > Am 07.03.2013 17:27, schrieb Christian Borntraeger: >> >>> It's a bug in both virtio-ccw that features=3D0 when get_features is >> >>> called. You can also tell this with: >> >>> >> >>> [10:02 AM] anthony@titi:~/git/qemu/hw/s390x$ grep DEFINE_VIRTIO_NET_= FEATURES * >> >>> virtio-ccw.c: DEFINE_VIRTIO_NET_FEATURES(VirtioCcwDevice, host_fe= atures[0]), >> >>> >> >>> So virtio-s390 is doing it wrong, but virtio-ccw looks like its doin= g it >> >>> right. >> >>=20 >> >> At least, this patch seems to work. (That also implies, that a transp= ort >> >> must not hide virtio feature bits). >> > >> > To me it indicates that the use of the old qdev property setters is >> > hiding errors resulting from trying to set not-existing properties. >> > If we would set the properties in a way that gets us an Error* on >> > failure like the object_property_set_*() do, we would notice on machine >> > creation (or device_add). >>=20 >> Hrm, I don't understand your statement. >>=20 >> Can you elaborate? >>=20 >> Regards, >>=20 >> Anthony Liguori > > > Well to me this indicates that s390 virtio is buggy. > It's not supposed to crash whatever set of features > we specify. Ack. Regards, Anthony Liguori