From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33845)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TjUZX-0007WM-N3
	for qemu-devel@nongnu.org; Fri, 14 Dec 2012 07:41:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TjUZW-0007xF-Lh
	for qemu-devel@nongnu.org; Fri, 14 Dec 2012 07:40:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:25240)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TjUZW-0007xB-EH
	for qemu-devel@nongnu.org; Fri, 14 Dec 2012 07:40:58 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBECetI6032479
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 14 Dec 2012 07:40:57 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <505C885E.6020507@redhat.com> (Paolo Bonzini's message of "Fri,
	21 Sep 2012 17:31:42 +0200")
References: <1348236500-2565-1-git-send-email-quintela@redhat.com>
	<1348236500-2565-8-git-send-email-quintela@redhat.com>
	<505C885E.6020507@redhat.com>
Date: Fri, 14 Dec 2012 13:40:45 +0100
Message-ID: <87a9tgg62a.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 07/14] migration: make writes blocking
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Orit Wasserman <owasserm@redhat.com>, qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 21/09/2012 16:08, Juan Quintela ha scritto:
>> -    s->fd = inet_connect(host_port, false, &in_progress, errp);
>> +    s->fd = inet_connect(host_port, true, &in_progress, errp);
>
> This makes the connect operation blocking.
>
> Does this mean that Orit's patches for non-blocking connect are not
> useful anymore?
>
> Or should we instead leave this as is, and later call socket_set_block?

fixed calling set-block.  Easier that way.

Later, Juan.