From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@titi.pok.ibm.com>) id 1SrxHh-0005IC-N8
	for qemu-devel@nongnu.org; Thu, 19 Jul 2012 16:25:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@titi.pok.ibm.com>) id 1SrxHg-0001kI-MS
	for qemu-devel@nongnu.org; Thu, 19 Jul 2012 16:25:17 -0400
Received: from e5.ny.us.ibm.com ([32.97.182.145]:54219)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@titi.pok.ibm.com>) id 1SrxHg-0001kC-IN
	for qemu-devel@nongnu.org; Thu, 19 Jul 2012 16:25:16 -0400
Received: from /spool/local
	by e5.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <anthony@titi.pok.ibm.com>;
	Thu, 19 Jul 2012 16:25:14 -0400
Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 8EA0038C8041
	for <qemu-devel@nongnu.org>; Thu, 19 Jul 2012 16:25:11 -0400 (EDT)
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q6JKPBFm255932
	for <qemu-devel@nongnu.org>; Thu, 19 Jul 2012 16:25:11 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q6JKP7gF026633
	for <qemu-devel@nongnu.org>; Thu, 19 Jul 2012 17:25:10 -0300
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <87bojdw2tx.fsf@blackfin.pond.sub.org>
References: <1342617545-9261-1-git-send-email-liwanp@linux.vnet.ibm.com>
	<1342617545-9261-5-git-send-email-liwanp@linux.vnet.ibm.com>
	<87bojdw2tx.fsf@blackfin.pond.sub.org>
Date: Thu, 19 Jul 2012 15:24:58 -0500
Message-ID: <87a9yvcxd1.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH v4 4/5] prepare to create HPET,
	RTC and i8254 through composition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Ramachandra Pai <pair@us.ibm.com>, Gavin Shan <shangw@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Liu Ping Fan <kernelfans@gmail.com>, Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <weil@mail.berlios.de>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Markus Armbruster <armbru@redhat.com> writes:

> Wanpeng Li <liwanp@linux.vnet.ibm.com> writes:
>
>> [CCing ML]
>>  
>>  From: Anthony Liguori <aliguori@us.ibm.com>
>>
>> The HPET usually sits on the LPC bus (which replaces ISA in modern systems).
>> It's sometimes a dedicated chip but can certain co-exist in a Super IO chip.
>> I think in terms of where it would live in this hypothetical device model,
>> putting it in the PIIX is rational.
>
> Could you explain briefly why you have to move struct definitions from
> .c to .h?

This patch shouldn't be in this series.  The reason to do this is so
that the PIIX3 can do composition and have the HPET/PIT as child
devices.  But that isn't in this series so having this patch isn't
useful.

Regards,

Anthony Liguori