From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4502C433F5 for ; Wed, 10 Nov 2021 16:33:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BB8161058 for ; Wed, 10 Nov 2021 16:33:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BB8161058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:55634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkqX7-0008Mm-Ix for qemu-devel@archiver.kernel.org; Wed, 10 Nov 2021 11:33:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkqVz-0006mr-9U for qemu-devel@nongnu.org; Wed, 10 Nov 2021 11:31:59 -0500 Received: from [2a00:1450:4864:20::432] (port=38479 helo=mail-wr1-x432.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkqVw-0005Uy-MF for qemu-devel@nongnu.org; Wed, 10 Nov 2021 11:31:58 -0500 Received: by mail-wr1-x432.google.com with SMTP id u18so5043427wrg.5 for ; Wed, 10 Nov 2021 08:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RRiMz3znJmGWhuKEgUxCPJ+EjQg7cBMkSSYp5MG1VIg=; b=pP6g+0oU09HXOhwLF3xgKP4RZE4Ur/iBOXkrQHGHzY9cRxTC4oHOb0v3y7bY+/m34D DG4tzjPOYBLv3U3GyzoQFIqKEbr2L+1rY3XsCN/VgHul02Q4pt2XIS1ux5Pu9MziQ+Dc tECC8sDRUl58rYMWafwD7AE6Slvg0sgIxMkZqt0hc3IuJnTO2V4PBnwX1j5hWJgvVw2p m2QCYQ1h4nDqhHl6At0wnHuPG9z4ADKYeUW9nuxhPkGGqrY+AwbC1juW2WuEBUCmO9lK uW4huWFO6z8ZnCxTXkNwDCfMGOdx/2Se/9sdxvW9vfzoPgkNNPu/LlN28QO5ANCi66So rXBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RRiMz3znJmGWhuKEgUxCPJ+EjQg7cBMkSSYp5MG1VIg=; b=Ft+/bW17gHhTwsQNL+J8qn8HXdFrpu2+mw7Fyumz9kfjGbrqJxcuhboj058JHH+hrF anqDq3u5HCJWBO6b9XcnXt6GFPrJCopTHPEbLYTxzk2muDsr2zqada/eypY1pUU+POpG +zjGoyKkXv/fGoQB428M1zkUZnQYS4qEdu776gJyg3ocy1T1anM5W7u9Ydv7BeHOGL/I hdpTb1vtExcCB4HqnfvrqJvohzBrA9mJkN3MCf//Ihu2AcFaRFMEnwigDrxF63WN6ZFV 4nHyKqupVRovf0k/xGau0cHAiiLqcYP0WHB+MTdAIDIVaLEDn4jtjJD3/3vjNU8MDNYS JnZw== X-Gm-Message-State: AOAM530gBhBDBtIfm10NM/qUe8r6OXRPU2zZwMEPPh7AqO69qKtAsWPB aKRg7w7LKEHfvQV94JW9NLV1OA== X-Google-Smtp-Source: ABdhPJwqQ6IZmEzBpTk3eru1sebkCdKminCQuwf1a/8S0jG4wpRqBQxOVT8q5YeT/UuLu50BFAj0Fw== X-Received: by 2002:adf:d1c2:: with SMTP id b2mr299919wrd.369.1636561914487; Wed, 10 Nov 2021 08:31:54 -0800 (PST) Received: from [192.168.8.106] (104.red-2-142-241.dynamicip.rima-tde.net. [2.142.241.104]) by smtp.gmail.com with ESMTPSA id p19sm279680wmq.4.2021.11.10.08.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Nov 2021 08:31:54 -0800 (PST) Subject: Re: [RFC 2/4] linux-user/signal.c: Create a common rewind_if_in_safe_syscall To: Warner Losh References: <20211108023738.42125-1-imp@bsdimp.com> <20211108023738.42125-3-imp@bsdimp.com> From: Richard Henderson Message-ID: <87bcf9b8-499c-c5e2-9d13-7afb0c58d991@linaro.org> Date: Wed, 10 Nov 2021 17:31:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::432 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.678, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philippe Mathieu-Daude , QEMU Developers , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/10/21 5:20 PM, Warner Losh wrote: > Although I think we can fairly safely drop HAVE_SAFE_SYSCALL.  It is required for > proper > operation.  As with host-signal.h, really. > > Yes. The only possible use I can see for it is to allow people to bring up new > platforms more easily by deferring the signal-safe system call details until later in > that process. > > If we do, we'd need to remove the linux-user on a mips host tests from the CI pipeline. > Those are the only ones left that don't use this that we test. Ack, thanks. I'll take care of this next release. r~