* [PATCH] trace/control-target: cleanup headers and make compilation unit common
@ 2025-03-05 5:07 Pierrick Bouvier
2025-03-10 17:17 ` Pierrick Bouvier
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Pierrick Bouvier @ 2025-03-05 5:07 UTC (permalink / raw)
To: qemu-devel
Cc: Mads Ynddal, alex.bennee, Stefan Hajnoczi, richard.henderson,
manos.pitsidianakis, philmd, Pierrick Bouvier
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
trace/control-target.c | 2 --
trace/meson.build | 4 +---
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/trace/control-target.c b/trace/control-target.c
index d58e84f6dd8..57ceac21084 100644
--- a/trace/control-target.c
+++ b/trace/control-target.c
@@ -8,8 +8,6 @@
*/
#include "qemu/osdep.h"
-#include "qemu/lockable.h"
-#include "cpu.h"
#include "trace/control.h"
diff --git a/trace/meson.build b/trace/meson.build
index c3412dc0ba5..3df45493555 100644
--- a/trace/meson.build
+++ b/trace/meson.build
@@ -1,6 +1,4 @@
-system_ss.add(files('trace-hmp-cmds.c'))
-
-specific_ss.add(files('control-target.c'))
+system_ss.add(files('control-target.c', 'trace-hmp-cmds.c'))
trace_events_files = []
foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] trace/control-target: cleanup headers and make compilation unit common
2025-03-05 5:07 [PATCH] trace/control-target: cleanup headers and make compilation unit common Pierrick Bouvier
@ 2025-03-10 17:17 ` Pierrick Bouvier
2025-03-10 17:53 ` Richard Henderson
2025-03-10 17:55 ` Alex Bennée
2025-03-11 2:12 ` Stefan Hajnoczi
2 siblings, 1 reply; 5+ messages in thread
From: Pierrick Bouvier @ 2025-03-10 17:17 UTC (permalink / raw)
To: qemu-devel
Cc: Mads Ynddal, alex.bennee, Stefan Hajnoczi, richard.henderson,
manos.pitsidianakis, philmd
On 3/4/25 21:07, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> trace/control-target.c | 2 --
> trace/meson.build | 4 +---
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/trace/control-target.c b/trace/control-target.c
> index d58e84f6dd8..57ceac21084 100644
> --- a/trace/control-target.c
> +++ b/trace/control-target.c
> @@ -8,8 +8,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/lockable.h"
> -#include "cpu.h"
> #include "trace/control.h"
>
>
> diff --git a/trace/meson.build b/trace/meson.build
> index c3412dc0ba5..3df45493555 100644
> --- a/trace/meson.build
> +++ b/trace/meson.build
> @@ -1,6 +1,4 @@
> -system_ss.add(files('trace-hmp-cmds.c'))
> -
> -specific_ss.add(files('control-target.c'))
> +system_ss.add(files('control-target.c', 'trace-hmp-cmds.c'))
>
> trace_events_files = []
> foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events
Hi folks,
gentle ping on this trivial change.
Regards,
Pierrick
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] trace/control-target: cleanup headers and make compilation unit common
2025-03-10 17:17 ` Pierrick Bouvier
@ 2025-03-10 17:53 ` Richard Henderson
0 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2025-03-10 17:53 UTC (permalink / raw)
To: Pierrick Bouvier, qemu-devel
Cc: Mads Ynddal, alex.bennee, Stefan Hajnoczi, manos.pitsidianakis,
philmd
On 3/10/25 10:17, Pierrick Bouvier wrote:
> On 3/4/25 21:07, Pierrick Bouvier wrote:
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> ---
>> trace/control-target.c | 2 --
>> trace/meson.build | 4 +---
>> 2 files changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/trace/control-target.c b/trace/control-target.c
>> index d58e84f6dd8..57ceac21084 100644
>> --- a/trace/control-target.c
>> +++ b/trace/control-target.c
>> @@ -8,8 +8,6 @@
>> */
>> #include "qemu/osdep.h"
>> -#include "qemu/lockable.h"
>> -#include "cpu.h"
>> #include "trace/control.h"
>> diff --git a/trace/meson.build b/trace/meson.build
>> index c3412dc0ba5..3df45493555 100644
>> --- a/trace/meson.build
>> +++ b/trace/meson.build
>> @@ -1,6 +1,4 @@
>> -system_ss.add(files('trace-hmp-cmds.c'))
>> -
>> -specific_ss.add(files('control-target.c'))
>> +system_ss.add(files('control-target.c', 'trace-hmp-cmds.c'))
>> trace_events_files = []
>> foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] trace/control-target: cleanup headers and make compilation unit common
2025-03-05 5:07 [PATCH] trace/control-target: cleanup headers and make compilation unit common Pierrick Bouvier
2025-03-10 17:17 ` Pierrick Bouvier
@ 2025-03-10 17:55 ` Alex Bennée
2025-03-11 2:12 ` Stefan Hajnoczi
2 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2025-03-10 17:55 UTC (permalink / raw)
To: Pierrick Bouvier
Cc: qemu-devel, Mads Ynddal, Stefan Hajnoczi, richard.henderson,
manos.pitsidianakis, philmd
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] trace/control-target: cleanup headers and make compilation unit common
2025-03-05 5:07 [PATCH] trace/control-target: cleanup headers and make compilation unit common Pierrick Bouvier
2025-03-10 17:17 ` Pierrick Bouvier
2025-03-10 17:55 ` Alex Bennée
@ 2025-03-11 2:12 ` Stefan Hajnoczi
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2025-03-11 2:12 UTC (permalink / raw)
To: Pierrick Bouvier
Cc: qemu-devel, Mads Ynddal, alex.bennee, richard.henderson,
manos.pitsidianakis, philmd
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
On Tue, Mar 04, 2025 at 09:07:16PM -0800, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> trace/control-target.c | 2 --
> trace/meson.build | 4 +---
> 2 files changed, 1 insertion(+), 5 deletions(-)
Thanks, applied to my tracing tree:
https://gitlab.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-11 2:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-05 5:07 [PATCH] trace/control-target: cleanup headers and make compilation unit common Pierrick Bouvier
2025-03-10 17:17 ` Pierrick Bouvier
2025-03-10 17:53 ` Richard Henderson
2025-03-10 17:55 ` Alex Bennée
2025-03-11 2:12 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).