From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E9A2C25B75 for ; Mon, 3 Jun 2024 08:45:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sE3Iy-0003Fr-Sw; Mon, 03 Jun 2024 04:44:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sE3Iw-0003FG-MJ for qemu-devel@nongnu.org; Mon, 03 Jun 2024 04:44:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sE3Iv-0002KP-4V for qemu-devel@nongnu.org; Mon, 03 Jun 2024 04:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717404271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wJUXvNhRMqBqfqb25jLGhqzSKH5XYAv3TIGqsziQ8eg=; b=J68P7NjvdgqZpK0z/A5nolVjwoJyU83fFFoletaqPkCG1U3Zogntjj1V7La5DfHSthfvVS 1nFjH/8Avqs/ShnzLW7DURBDSXew8/O++97viBhNiVcyvOeM+ul54KuGy+o879Oq7QxIdi zpMn5XtXvvsAh3pMfbNt2K9VH3DGjWQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-vnd4G63EPPyVyzo2UPPx4w-1; Mon, 03 Jun 2024 04:44:27 -0400 X-MC-Unique: vnd4G63EPPyVyzo2UPPx4w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA0298058D5; Mon, 3 Jun 2024 08:44:26 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.93]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A289D1C0654B; Mon, 3 Jun 2024 08:44:26 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8464C21E6757; Mon, 3 Jun 2024 10:44:25 +0200 (CEST) From: Markus Armbruster To: Thomas Huth Cc: Zhao Liu , Zide Chen , qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com, cfontana@suse.de, xiaoyao.li@intel.com, qemu-trivial@nongnu.org Subject: Re: [PATCH V2 1/3] vl: Allow multiple -overcommit commands In-Reply-To: <4d9c15c6-cfe7-4535-b41a-fbfcb1e5f970@redhat.com> (Thomas Huth's message of "Fri, 31 May 2024 06:57:31 +0200") References: <20240524200017.150339-1-zide.chen@intel.com> <20240524200017.150339-2-zide.chen@intel.com> <4d9c15c6-cfe7-4535-b41a-fbfcb1e5f970@redhat.com> Date: Mon, 03 Jun 2024 10:44:25 +0200 Message-ID: <87bk4ie7py.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Thomas Huth writes: > On 30/05/2024 16.01, Zhao Liu wrote: >> Hi Thomas, >> BTW, do you think it's a good idea to define the overcommit via QAPI way >> (defined in a json file)? ;-) >> My rough understanding is that all APIs are better to be defined via >> QAPI to go JSON compatible. > > Sorry, no clue whether it makes sense here... CC:-ing Markus for recommendations. I'd love to have a machine-friendly, QAPI-based CLI with a human-friendly CLI layered on top, similar to machine-friendly, QAPI-based QMP / human-friendly HMP. To get this with reasonable effort, we need better infrastructure. We have done a few complex options manually, such as -blockdev. I recommend this only when there's a clear need for JSON on the command line. I doubt this is the case for -overcommit.