From: Markus Armbruster <armbru@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v2] contrib/vhost-user-gpu: Fix compiler warning when compiling with -Wshadow
Date: Thu, 12 Oct 2023 17:17:16 +0200 [thread overview]
Message-ID: <87bkd3oooz.fsf@pond.sub.org> (raw)
In-Reply-To: <20231012090829-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Thu, 12 Oct 2023 09:08:56 -0400")
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Thu, Oct 12, 2023 at 02:18:44PM +0200, Markus Armbruster wrote:
>> Thomas Huth <thuth@redhat.com> writes:
>>
>> > Rename some variables to avoid compiler warnings when compiling
>> > with -Wshadow=local.
>> >
>> > Signed-off-by: Thomas Huth <thuth@redhat.com>
>> > ---
>> > v2: Renamed the variable to something more unique
[...]
>> v1 renamed to s_ instead, which I find much easier to read. Michael
>> asked you to change it so it's less likely to break if we pass it a
>> macro that also uses s_. Unlikely to happen, and would fail safe: build
>> breaks.
[...]
>> I'm going to queue v1. Michael, if you want me to queue v2 instead, or
>> neither of the two, let me know.
>
> Yea I think v2 is better, queue that please.
Done. Thanks!
prev parent reply other threads:[~2023-10-12 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 8:37 [PATCH v2] contrib/vhost-user-gpu: Fix compiler warning when compiling with -Wshadow Thomas Huth
2023-10-09 11:45 ` Michael S. Tsirkin
2023-10-09 12:05 ` Thomas Huth
2023-10-09 12:39 ` Markus Armbruster
2023-10-12 12:18 ` Markus Armbruster
2023-10-12 13:08 ` Michael S. Tsirkin
2023-10-12 15:17 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkd3oooz.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).