From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22C87CDB47E for ; Thu, 12 Oct 2023 11:38:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqu14-0004Cv-O4; Thu, 12 Oct 2023 07:38:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqu10-0004BM-Dm for qemu-devel@nongnu.org; Thu, 12 Oct 2023 07:38:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqu0y-0008Bz-Eu for qemu-devel@nongnu.org; Thu, 12 Oct 2023 07:38:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697110680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PAUv+xqM8/VuRfX2V5vyrBqaKjuDcWyZ4GKXWS/PSIY=; b=FHZaWvy5N6kNOUcEmywG4Q2N85PO68PtsD0OX9JC4SB0APgULSc3eoiqtPd2g9dvNHE/zx 7RKQbbiD+oqi/e4vl1S4bCnMxVhyyie9+d4x3ccVZ1eev0CGmXx+ma7EUbzGEAGs/qM3JV 3GGBDCSM8EyMnTdKrzVJANhiG0QyBGY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-OaPK4nk0MBqMTi092eW1_A-1; Thu, 12 Oct 2023 07:37:57 -0400 X-MC-Unique: OaPK4nk0MBqMTi092eW1_A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 653C7185A7B4; Thu, 12 Oct 2023 11:37:56 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B115C25C0; Thu, 12 Oct 2023 11:37:55 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A82D721E6A1F; Thu, 12 Oct 2023 13:37:54 +0200 (CEST) From: Markus Armbruster To: Nina Schoetterl-Glausch Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Eduardo Habkost , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , David Hildenbrand , Halil Pasic , Christian Borntraeger , Eric Farman , Thomas Huth , Eric Blake , Michael Roth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Yanan Wang , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Ilya Leoshkevich , Cleber Rosa , Wainer dos Santos Moschetta , Beraldo Leal , Pierre Morel Subject: Re: [PATCH v25 10/21] machine: adding s390 topology to query-cpu-fast References: <20231005160155.1945588-1-nsg@linux.ibm.com> <20231005160155.1945588-11-nsg@linux.ibm.com> Date: Thu, 12 Oct 2023 13:37:54 +0200 In-Reply-To: <20231005160155.1945588-11-nsg@linux.ibm.com> (Nina Schoetterl-Glausch's message of "Thu, 5 Oct 2023 18:01:44 +0200") Message-ID: <87bkd4ystp.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Nina Schoetterl-Glausch writes: > From: Pierre Morel > > S390x provides two more topology attributes, entitlement and dedication. > > Let's add these CPU attributes to the QAPI command query-cpu-fast. > > Signed-off-by: Pierre Morel > Reviewed-by: Nina Schoetterl-Glausch > Co-developed-by: Nina Schoetterl-Glausch > Reviewed-by: Thomas Huth > Signed-off-by: Nina Schoetterl-Glausch > --- > qapi/machine.json | 11 ++++++++++- > target/s390x/cpu.c | 9 +++++++++ > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/qapi/machine.json b/qapi/machine.json > index 7aacd26af0..072a12d168 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -57,9 +57,18 @@ > # > # @cpu-state: the virtual CPU's state > # > +# @dedicated: the virtual CPU's dedication (since 8.2) > +# > +# @entitlement: the virtual CPU's entitlement (since 8.2) > +# > # Since: 2.12 > ## > -{ 'struct': 'CpuInfoS390', 'data': { 'cpu-state': 'CpuS390State' } } > +{ 'struct': 'CpuInfoS390', > + 'data': { 'cpu-state': 'CpuS390State', > + '*dedicated': 'bool', > + '*entitlement': 'CpuS390Entitlement' > + } > +} A more common formatting is '*entitlement': 'CpuS390Entitlement' } } > > ## > # @CpuInfoFast: Acked-by: Markus Armbruster [...]