* [PATCH] target/m68k: Add URL to semihosting spec
@ 2023-08-01 15:44 Peter Maydell
2023-08-29 15:48 ` Peter Maydell
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Peter Maydell @ 2023-08-01 15:44 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier
The spec for m68k semihosting is documented in the libgloss
sources. Add a comment with the URL for it, as we already
have for nios2 semihosting.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/m68k/m68k-semi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
index 239f6e44e90..80cd8d70dbb 100644
--- a/target/m68k/m68k-semi.c
+++ b/target/m68k/m68k-semi.c
@@ -15,6 +15,10 @@
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <http://www.gnu.org/licenses/>.
+ *
+ * The semihosting protocol implemented here is described in the
+ * libgloss sources:
+ * https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=libgloss/m68k/m68k-semi.txt;hb=HEAD
*/
#include "qemu/osdep.h"
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] target/m68k: Add URL to semihosting spec
2023-08-01 15:44 [PATCH] target/m68k: Add URL to semihosting spec Peter Maydell
@ 2023-08-29 15:48 ` Peter Maydell
2023-09-12 14:14 ` Peter Maydell
2023-08-29 17:17 ` Richard Henderson
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2023-08-29 15:48 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier
On Tue, 1 Aug 2023 at 16:44, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> The spec for m68k semihosting is documented in the libgloss
> sources. Add a comment with the URL for it, as we already
> have for nios2 semihosting.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/m68k/m68k-semi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
> index 239f6e44e90..80cd8d70dbb 100644
> --- a/target/m68k/m68k-semi.c
> +++ b/target/m68k/m68k-semi.c
> @@ -15,6 +15,10 @@
> *
> * You should have received a copy of the GNU General Public License
> * along with this program; if not, see <http://www.gnu.org/licenses/>.
> + *
> + * The semihosting protocol implemented here is described in the
> + * libgloss sources:
> + * https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=libgloss/m68k/m68k-semi.txt;hb=HEAD
> */
>
> #include "qemu/osdep.h"
> --
Ping for review? I can take this through the arm tree if
you don't have an m68k pullreq planned.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] target/m68k: Add URL to semihosting spec
2023-08-29 15:48 ` Peter Maydell
@ 2023-09-12 14:14 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2023-09-12 14:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier
On Tue, 29 Aug 2023 at 16:48, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 1 Aug 2023 at 16:44, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > The spec for m68k semihosting is documented in the libgloss
> > sources. Add a comment with the URL for it, as we already
> > have for nios2 semihosting.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > target/m68k/m68k-semi.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
> > index 239f6e44e90..80cd8d70dbb 100644
> > --- a/target/m68k/m68k-semi.c
> > +++ b/target/m68k/m68k-semi.c
> > @@ -15,6 +15,10 @@
> > *
> > * You should have received a copy of the GNU General Public License
> > * along with this program; if not, see <http://www.gnu.org/licenses/>.
> > + *
> > + * The semihosting protocol implemented here is described in the
> > + * libgloss sources:
> > + * https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=libgloss/m68k/m68k-semi.txt;hb=HEAD
> > */
> >
> > #include "qemu/osdep.h"
> > --
>
> Ping for review? I can take this through the arm tree if
> you don't have an m68k pullreq planned.
Picked up for target-arm.next.
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target/m68k: Add URL to semihosting spec
2023-08-01 15:44 [PATCH] target/m68k: Add URL to semihosting spec Peter Maydell
2023-08-29 15:48 ` Peter Maydell
@ 2023-08-29 17:17 ` Richard Henderson
2023-08-29 17:36 ` Alex Bennée
2023-08-29 19:28 ` Philippe Mathieu-Daudé
3 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2023-08-29 17:17 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Laurent Vivier
On 8/1/23 08:44, Peter Maydell wrote:
> The spec for m68k semihosting is documented in the libgloss
> sources. Add a comment with the URL for it, as we already
> have for nios2 semihosting.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> target/m68k/m68k-semi.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target/m68k: Add URL to semihosting spec
2023-08-01 15:44 [PATCH] target/m68k: Add URL to semihosting spec Peter Maydell
2023-08-29 15:48 ` Peter Maydell
2023-08-29 17:17 ` Richard Henderson
@ 2023-08-29 17:36 ` Alex Bennée
2023-08-29 19:28 ` Philippe Mathieu-Daudé
3 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2023-08-29 17:36 UTC (permalink / raw)
To: Peter Maydell; +Cc: Laurent Vivier, qemu-devel
Peter Maydell <peter.maydell@linaro.org> writes:
> The spec for m68k semihosting is documented in the libgloss
> sources. Add a comment with the URL for it, as we already
> have for nios2 semihosting.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/m68k/m68k-semi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
> index 239f6e44e90..80cd8d70dbb 100644
> --- a/target/m68k/m68k-semi.c
> +++ b/target/m68k/m68k-semi.c
> @@ -15,6 +15,10 @@
> *
> * You should have received a copy of the GNU General Public License
> * along with this program; if not, see <http://www.gnu.org/licenses/>.
> + *
> + * The semihosting protocol implemented here is described in the
> + * libgloss sources:
> + * https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=libgloss/m68k/m68k-semi.txt;hb=HEAD
> */
>
> #include "qemu/osdep.h"
Matches what we reference in emulation.rst so:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target/m68k: Add URL to semihosting spec
2023-08-01 15:44 [PATCH] target/m68k: Add URL to semihosting spec Peter Maydell
` (2 preceding siblings ...)
2023-08-29 17:36 ` Alex Bennée
@ 2023-08-29 19:28 ` Philippe Mathieu-Daudé
3 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-29 19:28 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Laurent Vivier
On 1/8/23 17:44, Peter Maydell wrote:
> The spec for m68k semihosting is documented in the libgloss
> sources. Add a comment with the URL for it, as we already
> have for nios2 semihosting.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/m68k/m68k-semi.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-12 14:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-01 15:44 [PATCH] target/m68k: Add URL to semihosting spec Peter Maydell
2023-08-29 15:48 ` Peter Maydell
2023-09-12 14:14 ` Peter Maydell
2023-08-29 17:17 ` Richard Henderson
2023-08-29 17:36 ` Alex Bennée
2023-08-29 19:28 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).