From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-arm@nongnu.org,
"Evgeny Iakovlev" <eiakovlev@linux.microsoft.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH 02/12] util/fifo8: Allow fifo8_pop_buf() to not populate popped length
Date: Tue, 23 May 2023 14:25:07 +0100 [thread overview]
Message-ID: <87bkib5gef.fsf@linaro.org> (raw)
In-Reply-To: <20230522153144.30610-3-philmd@linaro.org>
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> There might be cases where we know the number of bytes we can
> pop from the FIFO, or we simply don't care how many bytes is
> returned. Allow fifo8_pop_buf() to take a NULL numptr.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-05-23 13:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 15:31 [PATCH 00/12] hw/char/pl011: Implement TX (async) FIFO to avoid blocking the main loop Philippe Mathieu-Daudé
2023-05-22 15:31 ` [PATCH 01/12] util/fifo8: Fix typo in fifo8_push_all() description Philippe Mathieu-Daudé
2023-05-22 19:06 ` Francisco Iglesias
2023-05-23 13:22 ` Alex Bennée
2023-05-22 15:31 ` [PATCH 02/12] util/fifo8: Allow fifo8_pop_buf() to not populate popped length Philippe Mathieu-Daudé
2023-05-22 19:13 ` Francisco Iglesias
2023-05-23 13:25 ` Alex Bennée [this message]
2023-05-22 15:31 ` [PATCH 03/12] util/fifo8: Introduce fifo8_peek_buf() Philippe Mathieu-Daudé
2023-05-22 19:38 ` Francisco Iglesias
2023-05-23 13:25 ` Alex Bennée
2023-05-22 15:31 ` [PATCH 04/12] hw/char/pl011: Display register name in trace events Philippe Mathieu-Daudé
2023-05-23 13:31 ` Alex Bennée
2023-05-22 15:31 ` [PATCH 05/12] hw/char/pl011: Remove duplicated PL011_INT_[RT]X definitions Philippe Mathieu-Daudé
2023-05-23 13:32 ` Alex Bennée
2023-05-22 15:31 ` [PATCH 06/12] hw/char/pl011: Replace magic values by register field definitions Philippe Mathieu-Daudé
2023-05-23 13:34 ` Alex Bennée
2023-05-22 15:31 ` [PATCH 07/12] hw/char/pl011: Split RX/TX path of pl011_reset_fifo() Philippe Mathieu-Daudé
2023-05-23 13:35 ` Alex Bennée
2023-05-22 15:31 ` [PATCH 08/12] hw/char/pl011: Extract pl011_write_tx() from pl011_write() Philippe Mathieu-Daudé
2023-05-23 13:36 ` Alex Bennée
2023-05-22 15:31 ` [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled Philippe Mathieu-Daudé
2023-05-23 13:36 ` Alex Bennée
2023-05-25 12:30 ` Peter Maydell
2023-05-25 12:51 ` Alex Bennée
2023-05-25 12:55 ` Peter Maydell
2023-05-25 13:17 ` Philippe Mathieu-Daudé
2023-05-22 15:31 ` [PATCH 10/12] hw/char/pl011: Check if receiver " Philippe Mathieu-Daudé
2023-05-23 13:38 ` Alex Bennée
2023-05-22 15:31 ` [PATCH 11/12] hw/char/pl011: Rename RX FIFO methods Philippe Mathieu-Daudé
2023-05-23 13:39 ` Alex Bennée
2023-05-22 15:31 ` [PATCH 12/12] hw/char/pl011: Implement TX FIFO Philippe Mathieu-Daudé
2023-05-23 13:47 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkib5gef.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=eiakovlev@linux.microsoft.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).