Re: [PULL SUBSYSTEM arm 0/8] TivaC Implementation

["Alex Bennée" <alex.bennee@linaro.org>]

Mohamed ElSayed <m.elsayed4420@gmail.com> writes:

> ***
> This is an implementation for the TivaC board.
> For now it models the system control block, the general purpose I/O, the general purpose timers, the watchdog timers and the usart module.
>
> The code is available at https://github.com/moesay/qemu_TivaC.git
> ***

Hi Mohamed,

I'm afraid this pull request won't get processed. Pull requests are sent
by maintainers who are listed in the MAINTAINERS file with signed PRs.
If you want to get support for the TivacC board up-streamed you should
post a series of patches and participate in code review. We have some
general guidance for the process here:

  https://qemu.readthedocs.io/en/latest/devel/submitting-a-patch.html

A couple of general points to get you started:

 - patch 7

   This is obviously wrong as it updates the project README with your
   personal fork information.

 - patch 8

   code format fixes to your own code should be folded into the relevant commit

 - use of qemu_log

   direct use of qemu_log is discouraged. Generally for devices you
   would be using qemu_log_mask with LOG_UNIMP or LOG_GUEST_ERROR as
   appropriate. Think about if the log point would be better handled at
   a tracepoint (or removed completely if it was a debugging aid during
   development).

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro