From: Markus Armbruster <armbru@redhat.com>
To: Bernhard Beschow <shentey@gmail.com>
Cc: qemu-devel@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 1/7] hw/acpi: Add missing includes
Date: Mon, 16 Jan 2023 14:02:23 +0100 [thread overview]
Message-ID: <87bkmyaazk.fsf@pond.sub.org> (raw)
In-Reply-To: <ED034842-BBE4-4C6A-8E39-105BCBB58F6D@gmail.com> (Bernhard Beschow's message of "Mon, 16 Jan 2023 08:56:56 +0000")
Bernhard Beschow <shentey@gmail.com> writes:
> Am 16. Januar 2023 06:46:36 UTC schrieb Markus Armbruster <armbru@redhat.com>:
>>Bernhard Beschow <shentey@gmail.com> writes:
>>
>>> When removing the "hw/boards.h" include from
>>> hw/acpi/acpi_dev_interface.h, these include directives must be added to make
>>> the code compile again.
>>>
>>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>>
>>You don't actually remove #include "hw/boards.h" from
>>hw/acpi/acpi_dev_interface.h in this series. Accident?
>
> It gets removed in "[PATCH 3/7] hw/acpi/acpi_dev_interface: Resolve AcpiDeviceIfClass::madt_cpu", no?
Got eaten on the way to me, and I didn't notice, because git-am is still
happy. Sorry for the noise!
The commit message could point to PATCH 3. However, I'd reshuffle a bit
instead. Split PATCH 3 into everything but the removal of #include
"hw/boards.h", and the removal. Squash PATCH 1 into the latter,
resulting in a straighforward cleanup patch.
next prev parent reply other threads:[~2023-01-16 13:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 22:27 [PATCH 0/7] AML Housekeeping Bernhard Beschow
2023-01-14 22:27 ` [PATCH 1/7] hw/acpi: Add missing includes Bernhard Beschow
2023-01-16 6:46 ` Markus Armbruster
2023-01-16 8:56 ` Bernhard Beschow
2023-01-16 13:02 ` Markus Armbruster [this message]
2023-01-16 13:30 ` Bernhard Beschow
2023-01-14 22:27 ` [PATCH 2/7] hw/acpi/acpi_dev_interface: Remove unused parameter from AcpiDeviceIfClass::madt_cpu Bernhard Beschow
2023-01-16 15:51 ` Igor Mammedov
2023-01-14 22:27 ` [PATCH 3/7] hw/acpi/acpi_dev_interface: Resolve AcpiDeviceIfClass::madt_cpu Bernhard Beschow
2023-01-14 22:27 ` [PATCH 4/7] hw/i386/acpi-build: Remove unused attributes Bernhard Beschow
2023-01-16 9:09 ` Philippe Mathieu-Daudé
2023-01-14 22:27 ` [PATCH 5/7] hw/acpi/acpi_aml_interface: Extract qbus_build_aml() Bernhard Beschow
2023-01-16 9:13 ` Philippe Mathieu-Daudé
2023-01-14 22:27 ` [PATCH 6/7] hw/i386/acpi-microvm: Reuse qbus_build_aml() Bernhard Beschow
2023-01-16 9:14 ` Philippe Mathieu-Daudé
2023-01-16 14:02 ` Bernhard Beschow
2023-01-16 14:18 ` Bernhard Beschow
2023-01-16 14:22 ` Philippe Mathieu-Daudé
2023-01-14 22:27 ` [PATCH 7/7] hw/isa/isa-bus: Remove now unused isa_build_aml() Bernhard Beschow
2023-01-16 9:14 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkmyaazk.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=ani@anisinha.ca \
--cc=aurelien@aurel32.net \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).