From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>, Ed Maste <emaste@freebsd.org>,
Christian Schoenebeck <qemu_oss@crudebyte.com>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Stefan Weil <sw@weilnetz.de>, Paolo Bonzini <pbonzini@redhat.com>,
Li-Wen Hsu <lwhsu@freebsd.org>
Subject: Re: [PATCH 2/2] cirrus.yml: Update the FreeBSD task to version 12.2
Date: Wed, 17 Mar 2021 16:24:35 +0000 [thread overview]
Message-ID: <87blbhd9ti.fsf@linaro.org> (raw)
In-Reply-To: <YFIANJSi+FtVRYQY@redhat.com>
Daniel P. Berrangé <berrange@redhat.com> writes:
> On Wed, Mar 17, 2021 at 01:44:05PM +0100, Thomas Huth wrote:
>> On 17/03/2021 12.16, Peter Maydell wrote:
>> > On Wed, 17 Mar 2021 at 11:09, Thomas Huth <thuth@redhat.com> wrote:
>> > >
>> > > FreeBSD version 12.1 is out of service now, and the task in the
>> > > Cirrus-CI is failing. Update to 12.2 to get it working again.
>> > > Unfortunately, there is a bug in libtasn1 that triggers with the
>> > > new version of Clang that is used there (see this thread for details:
>> > > https://lists.gnu.org/archive/html/qemu-dove/2021-02/msg00739.html ),
>> > > so we have to disable gnutls for now to make it work again. We can
>> > > enable it later again once libtasn1 has been fixed in FreeBSD.
>> > >
>> > > Signed-off-by: Thomas Huth <thuth@redhat.com>
>> >
>> > Is it feasible to make configure check for "is libtasn1 broken"?
>> > I guess since it only shows up as "when you try to use it
>> > it fails" that would be a runtime check rather than compile
>> > time, which isn't really possible :-(
>>
>> I don't really have a clue about this crypto stuff... Daniel, Stefan, Roman,
>> Christian, Eric ... you debugged the original problem on macOS, do you think
>> it's possible to add a check for this libtasn1 problem to our "configure"
>> (or meson.build file)?
>
> It is tricky because the flaw is not specific to the version of
> tasn1, rather to the combination of tasn1 and the compiler used,
> so there's no simple way to detect it statically from configure.
>
> If don't want the big hammer of disabling gnutls, perhaps adding
> a flag to disable tasn1 would be simpler, as that would only
> disable test suite, and no actual QEMU core functionality (which
> is all working fine)
I suspect we'll forget to remove this flag as well when the time comes.
Without adding new things I think this patch would be fine with an
additional comments:
# --disable-gnutls until libtasn1 is fixed in FreeBSD (#ref?)
>
> Regards,
> Daniel
--
Alex Bennée
next prev parent reply other threads:[~2021-03-17 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 11:05 [PATCH 0/2] Fix atomic test in "configure" + bump FreeBSD CI to 12.2 Thomas Huth
2021-03-17 11:05 ` [PATCH 1/2] configure: Don't use the __atomic_*_16 functions for testing 128-bit support Thomas Huth
2021-03-17 12:03 ` Paolo Bonzini
2021-03-17 15:22 ` Richard Henderson
2021-03-17 11:05 ` [PATCH 2/2] cirrus.yml: Update the FreeBSD task to version 12.2 Thomas Huth
2021-03-17 11:16 ` Peter Maydell
2021-03-17 12:44 ` Thomas Huth
2021-03-17 13:12 ` Daniel P. Berrangé
2021-03-17 16:24 ` Alex Bennée [this message]
2021-03-19 10:14 ` [PATCH v2 " Thomas Huth
2021-03-17 13:16 ` [PATCH " Roman Bolshakov
2021-03-17 13:24 ` Peter Maydell
2021-03-19 15:33 ` [PATCH 0/2] Fix atomic test in "configure" + bump FreeBSD CI to 12.2 Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blbhd9ti.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=emaste@freebsd.org \
--cc=lwhsu@freebsd.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).