From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZtwtZ-0002IL-Ax
	for qemu-devel@nongnu.org; Wed, 04 Nov 2015 07:10:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZtwtU-0007Ce-Bw
	for qemu-devel@nongnu.org; Wed, 04 Nov 2015 07:10:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33456)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZtwtU-0007CB-6k
	for qemu-devel@nongnu.org; Wed, 04 Nov 2015 07:10:24 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1446636716-9721-2-git-send-email-den@openvz.org> (Denis
	V. Lunev's message of "Wed, 4 Nov 2015 14:31:56 +0300")
References: <87ziyuksbw.fsf@emacs.mitica>
	<1446636716-9721-1-git-send-email-den@openvz.org>
	<1446636716-9721-2-git-send-email-den@openvz.org>
Date: Wed, 04 Nov 2015 13:10:21 +0100
Message-ID: <87bnbac6du.fsf@emacs.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC 2/2] snapshot: create
	bdrv_snapshot_all_del_snapshot helper
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

"Denis V. Lunev" <den@openvz.org> wrote:
> to delete snapshots from all loaded block drivers.
>
> The patch also ensures proper locking.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Juan Quintela <quintela@redhat.com>
> ---
>  block/snapshot.c         | 27 ++++++++++++++++++++++++
>  include/block/snapshot.h |  2 ++
>  migration/savevm.c       | 54 +++++++++---------------------------------------
>  3 files changed, 39 insertions(+), 44 deletions(-)
>
> diff --git a/block/snapshot.c b/block/snapshot.c
> index 6b5ce4e..9d1aa9b 100644
> --- a/block/snapshot.c
> +++ b/block/snapshot.c
> @@ -391,3 +391,30 @@ bool bdrv_snapshot_all_can_snapshot(BlockDriverState **first_bad_bs)
>      *first_bad_bs = NULL;
>      return true;
>  }
> +
> +int bdrv_snapshot_all_del_snapshot(const char *name,

bdrv_snapshot_delete_all?
bdrv_snapshot_delete_all_snapshots?

Agreed with the patches.

Reviewed-by: Juan Quintela <quintela@redhat.com>