From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVOB6-00061a-VI for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:42:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVOAv-0003z0-DS for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:42:48 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:58888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVOAu-0003yY-Q7 for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:42:37 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Mar 2015 23:12:34 +0530 From: "Aneesh Kumar K.V" In-Reply-To: <1425838674-28393-1-git-send-email-sw@weilnetz.de> References: <1425838674-28393-1-git-send-email-sw@weilnetz.de> Date: Tue, 10 Mar 2015 23:12:29 +0530 Message-ID: <87bnk0rbp6.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/7] 9pfs: Fix warnings from Sparse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , QEMU Trivial Cc: QEMU Developer , "Michael S. Tsirkin" Stefan Weil writes: > Sparse report: > > 9pfs/virtio-9p.c:1953:9: warning: returning void-valued expression > 9pfs/virtio-9p-handle.c:143:5: warning: returning void-valued expression > 9pfs/virtio-9p-handle.c:160:5: warning: returning void-valued expression > 9pfs/virtio-9p-local.c:384:5: warning: returning void-valued expression > 9pfs/virtio-9p-local.c:415:5: warning: returning void-valued expression > 9pfs/virtio-9p-proxy.c:672:5: warning: returning void-valued expression > 9pfs/virtio-9p-proxy.c:689:5: warning: returning void-valued expression > > Cc: Michael S. Tsirkin > Cc: Aneesh Kumar K.V > Signed-off-by: Stefan Weil Reviewed-by: Aneesh Kumar K.V > --- > hw/9pfs/virtio-9p-handle.c | 4 ++-- > hw/9pfs/virtio-9p-local.c | 4 ++-- > hw/9pfs/virtio-9p-proxy.c | 4 ++-- > hw/9pfs/virtio-9p.c | 3 ++- > 4 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c > index 4b79cef..13eabb9 100644 > --- a/hw/9pfs/virtio-9p-handle.c > +++ b/hw/9pfs/virtio-9p-handle.c > @@ -140,7 +140,7 @@ static int handle_opendir(FsContext *ctx, > > static void handle_rewinddir(FsContext *ctx, V9fsFidOpenState *fs) > { > - return rewinddir(fs->dir); > + rewinddir(fs->dir); > } > > static off_t handle_telldir(FsContext *ctx, V9fsFidOpenState *fs) > @@ -157,7 +157,7 @@ static int handle_readdir_r(FsContext *ctx, V9fsFidOpenState *fs, > > static void handle_seekdir(FsContext *ctx, V9fsFidOpenState *fs, off_t off) > { > - return seekdir(fs->dir, off); > + seekdir(fs->dir, off); > } > > static ssize_t handle_preadv(FsContext *ctx, V9fsFidOpenState *fs, > diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c > index a183eee..fec580b 100644 > --- a/hw/9pfs/virtio-9p-local.c > +++ b/hw/9pfs/virtio-9p-local.c > @@ -381,7 +381,7 @@ static int local_opendir(FsContext *ctx, > > static void local_rewinddir(FsContext *ctx, V9fsFidOpenState *fs) > { > - return rewinddir(fs->dir); > + rewinddir(fs->dir); > } > > static off_t local_telldir(FsContext *ctx, V9fsFidOpenState *fs) > @@ -412,7 +412,7 @@ again: > > static void local_seekdir(FsContext *ctx, V9fsFidOpenState *fs, off_t off) > { > - return seekdir(fs->dir, off); > + seekdir(fs->dir, off); > } > > static ssize_t local_preadv(FsContext *ctx, V9fsFidOpenState *fs, > diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c > index 59c7445..edab402 100644 > --- a/hw/9pfs/virtio-9p-proxy.c > +++ b/hw/9pfs/virtio-9p-proxy.c > @@ -669,7 +669,7 @@ static int proxy_opendir(FsContext *ctx, > > static void proxy_rewinddir(FsContext *ctx, V9fsFidOpenState *fs) > { > - return rewinddir(fs->dir); > + rewinddir(fs->dir); > } > > static off_t proxy_telldir(FsContext *ctx, V9fsFidOpenState *fs) > @@ -686,7 +686,7 @@ static int proxy_readdir_r(FsContext *ctx, V9fsFidOpenState *fs, > > static void proxy_seekdir(FsContext *ctx, V9fsFidOpenState *fs, off_t off) > { > - return seekdir(fs->dir, off); > + seekdir(fs->dir, off); > } > > static ssize_t proxy_preadv(FsContext *ctx, V9fsFidOpenState *fs, > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > index 5861a5b..4964da0 100644 > --- a/hw/9pfs/virtio-9p.c > +++ b/hw/9pfs/virtio-9p.c > @@ -1950,7 +1950,8 @@ static void v9fs_write(void *opaque) > > err = pdu_unmarshal(pdu, offset, "dqd", &fid, &off, &count); > if (err < 0) { > - return complete_pdu(s, pdu, err); > + complete_pdu(s, pdu, err); > + return; > } > offset += err; > v9fs_init_qiov_from_pdu(&qiov_full, pdu, offset, count, true); > -- > 2.1.4