From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54479)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1XeQqW-0005Qz-Ct
	for qemu-devel@nongnu.org; Wed, 15 Oct 2014 11:50:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1XeQqP-0001zx-Ux
	for qemu-devel@nongnu.org; Wed, 15 Oct 2014 11:50:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29857)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1XeQqP-0001zp-Kl
	for qemu-devel@nongnu.org; Wed, 15 Oct 2014 11:50:33 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9FFoW5G015429
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 15 Oct 2014 11:50:33 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <543E87CD.9010305@redhat.com> (Eric Blake's message of "Wed, 15
	Oct 2014 08:42:21 -0600")
References: <1413359710-2799-1-git-send-email-quintela@redhat.com>
	<1413359710-2799-5-git-send-email-quintela@redhat.com>
	<543E87CD.9010305@redhat.com>
Date: Wed, 15 Oct 2014 17:50:21 +0200
Message-ID: <87bnpdfi2q.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 4/7] runstate: migration allows more
	transitions now
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, laine@redhat.com, lcapitulino@redhat.com

Eric Blake <eblake@redhat.com> wrote:
> On 10/15/2014 01:55 AM, Juan Quintela wrote:
>> Next commit would allow to move from incoming migration to error
>> happening on source.
>> 
>> Should we add more states to this transition?  Luiz?
>
> Does this mean we can finally do S3 migration without forcing the guest
> to wake up from S3 on the destination?

I haven't tested, but it should just work (famous last words).

Would test.

Later, Juan.

>
>> 
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  vl.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/vl.c b/vl.c
>> index c4bc43c..1788b6a 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -618,6 +618,8 @@ static const RunStateTransition runstate_transitions_def[] = {
>> 
>>      { RUN_STATE_INMIGRATE, RUN_STATE_RUNNING },
>>      { RUN_STATE_INMIGRATE, RUN_STATE_PAUSED },
>> +    { RUN_STATE_INMIGRATE, RUN_STATE_INTERNAL_ERROR },
>> +    { RUN_STATE_INMIGRATE, RUN_STATE_IO_ERROR },
>> 
>>      { RUN_STATE_INTERNAL_ERROR, RUN_STATE_PAUSED },
>>      { RUN_STATE_INTERNAL_ERROR, RUN_STATE_FINISH_MIGRATE },
>>