From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54044)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1XTxKY-0004M5-OM
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 14:18:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1XTxKT-0004da-JU
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 14:18:22 -0400
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:41159 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1XTxKT-0004cH-Dy
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 14:18:17 -0400
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
References: <1410626734-3804-1-git-send-email-rth@twiddle.net>
	<1410626734-3804-8-git-send-email-rth@twiddle.net>
In-reply-to: <1410626734-3804-8-git-send-email-rth@twiddle.net>
Date: Tue, 16 Sep 2014 19:18:06 +0100
Message-ID: <87bnqffmzl.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 07/23] target-xtensa: Use
	cpu_exec_interrupt	qom hook
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Max Filippov <jcmvbkbc@gmail.com>, peter.maydell@linaro.org, qemu-devel@nongnu.org, aliguori@amazon.com, afaerber@suse.de


Richard Henderson writes:

> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
<snip>
> @@ -669,12 +669,6 @@ int cpu_exec(CPUArchState *env)
>                          cc->do_interrupt(cpu);
>                          next_tb = 0;
>                      }
> -#elif defined(TARGET_XTENSA)
> -                    if (interrupt_request & CPU_INTERRUPT_HARD) {
> -                        cpu->exception_index = EXC_IRQ;
> -                        cc->do_interrupt(cpu);
> -                        next_tb = 0;
> -                    }
>  #endif
<snip>
>  
>  void xtensa_cpu_do_interrupt(CPUState *cpu);
> +bool xtensa_cpu_exec_interrupt(CPUState *cpu, int interrupt_request);
<snip>
>      cc->do_interrupt = xtensa_cpu_do_interrupt;
> +    cc->cpu_exec_interrupt = xtensa_cpu_exec_interrupt;
<snip>
>  
> +bool xtensa_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
> +{
> +    if (interrupt_request & CPU_INTERRUPT_HARD) {
> +        cs->exception_index = EXC_IRQ;
> +        xtensa_cpu_do_interrupt(cs);
> +        return true;
> +    }
> +    return false;
<snip>

Do this mean when all this unwinding has occured cc->do_interrupt will
no longer be needed at all entries will go in via
$ARCH_cpu_exec_interrupt?

-- 
Alex Bennée