From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WAmHM-0001jW-Um
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 15:07:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WAmHG-0004sF-F3
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 15:07:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38774)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WAmHG-0004s7-7G
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 15:07:26 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20140204173404.GE2733@work-vm> (David Alan Gilbert's message of
	"Tue, 4 Feb 2014 17:34:05 +0000")
References: <1391527185-28349-1-git-send-email-quintela@redhat.com>
	<1391527185-28349-8-git-send-email-quintela@redhat.com>
	<20140204173404.GE2733@work-vm>
Date: Tue, 04 Feb 2014 21:07:20 +0100
Message-ID: <87bnymiqvb.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 7/8] Don't abort on memory allocation error
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Orit Wasserman <owasserm@redhat.com>, qemu-devel@nongnu.org, anthony@codemonkey.ws

"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Juan Quintela (quintela@redhat.com) wrote:
>> From: Orit Wasserman <owasserm@redhat.com>
>
>>      if (!it->it_data) {
>>          cache->num_items++;
>> +        it->it_data = g_try_malloc(cache->page_size);
>> +        if (!it->it_data) {
>> +            DPRINTF("Error allocating page\n");
>> +            return -1;
>> +        }
>
> Hmm that wasn't the latest version of that patch (or the previous
> one in the series).

Error on my part, already Nacked and sent a new version.

Later, Juan.