From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6Nsw-0006fv-M7 for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:43:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6Nss-0001Go-4c for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:43:54 -0400 Received: from mail-oa0-f54.google.com ([209.85.219.54]:59134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6Nss-0001GL-0X for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:43:50 -0400 Received: by mail-oa0-f54.google.com with SMTP id o6so6807691oag.13 for ; Mon, 05 Aug 2013 09:43:49 -0700 (PDT) From: Anthony Liguori In-Reply-To: <51FFAC0D.1070300@suse.de> References: <1375567378-5089-1-git-send-email-aurelien@aurel32.net> <51FE4308.5010208@suse.de> <20130804220647.GB4193@ohm.aurel32.net> <51FFAC0D.1070300@suse.de> Date: Mon, 05 Aug 2013 11:43:46 -0500 Message-ID: <87bo5culz1.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for 1.6] mips: revert commit b332d24a8e1290954029814d09156b06ede358e2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= , Aurelien Jarno Cc: Peter Maydell , qemu-devel@nongnu.org Andreas F=C3=A4rber writes: > Am 05.08.2013 00:06, schrieb Aurelien Jarno: >> On Sun, Aug 04, 2013 at 02:03:20PM +0200, Andreas F=C3=A4rber wrote: >>> Am 04.08.2013 00:02, schrieb Aurelien Jarno: >>>> Now that this code path is not triggered anymore during the tests, >>>> revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS >>>> target without kernel nor bios doesn't really make sense. >>>> >>>> Signed-off-by: Aurelien Jarno >>> >>> This is being discussed in http://patchwork.ozlabs.org/patch/262912/ - >>> so far Anthony has put a hold on further such changes unfortunately. >>> >>=20 >> This has been an error for more than 6 years, and nobody complained so >> far. > > Neither QOM nor qtest exist for 6 years, so that is not an argument for > everything. ;) > >> I understand that the machines should be testable with qtest, but >> such as change has been merged already. Now there is no reason to not >> fix this *regression* from version 1.5. > > Ah, you mean this? > http://git.qemu.org/?p=3Dqemu.git;a=3Dcommit;h=3Db332d24a8e1290954029814d= 09156b06ede358e2 > Wasn't aware. No objection to exit(1) from my side then. > > But either way, you shouldn't replace one fprintf() with another > fprintf() but instead use our new error_report() if you touch it > (without trailing \n then). I've updated my qtest enablement series to > use it, v2 handles some more machines. > >> People should understand that QEMU is not only x86, and that not >> everything should be done the x86 way. > > No need to explain that to me. I don't object to adding the exit(1) FWIW. But I also think we should think more about having consistent behavior across platforms. It's unexpected that qemu-system-x86_64 does something and qemu-system-mips does something else. Maybe -x86_64 should barf is not given anything bootable... Regards, Anthony Liguori > > I think Anthony's question was rather whether printing random text to > stderr is the best way to address that or whether QEMUMachine could use > some this-machine-needs-a-kernel flag that libvirt or someone can access > and that could be handled in a central place rather than in each machine > as they see fit. > > But with the release near and no concrete patches, I don't think that's > 1.6 material. Question is, do we want test cases based on cleanups that > work today in 1.6 and work from there, or do we rather wait 'til after > the release and if so, can we get them merged early so that other series > can actually be tested with them. > > Regards, > Andreas > > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg