From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoFPv-0006MX-JZ for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:03:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoFPt-0000KM-57 for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:02:59 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:33291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoFPs-0000KE-U7 for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:02:57 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 16 Jun 2013 10:02:56 -0600 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id A5EFFC90041 for ; Sun, 16 Jun 2013 12:02:52 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5GG2rfl342756 for ; Sun, 16 Jun 2013 12:02:53 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5GG2qCj028236 for ; Sun, 16 Jun 2013 12:02:53 -0400 From: Anthony Liguori In-Reply-To: <1371397053-4503-3-git-send-email-lilei@linux.vnet.ibm.com> References: <1371397053-4503-1-git-send-email-lilei@linux.vnet.ibm.com> <1371397053-4503-3-git-send-email-lilei@linux.vnet.ibm.com> Date: Sun, 16 Jun 2013 11:02:49 -0500 Message-ID: <87bo76hwly.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 2/7] savevm: export qemu_save_device_state() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li , qemu-devel@nongnu.org Cc: lagarcia@br.ibm.com, quintela@redhat.com Lei Li writes: > Signed-off-by: Lei Li > --- > include/sysemu/sysemu.h | 1 + > savevm.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 2fb71af..5b90027 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -80,6 +80,7 @@ int qemu_savevm_state_iterate(QEMUFile *f); > void qemu_savevm_state_complete(QEMUFile *f); > void qemu_savevm_state_cancel(void); > uint64_t qemu_savevm_state_pending(QEMUFile *f, uint64_t max_size); > +int qemu_save_device_state(QEMUFile *f); > int qemu_loadvm_state(QEMUFile *f); Please add comments describing what this function does. I know they're absent for the rest of the functions but we have to start somewhere. Regards, Anthony Liguori > > /* SLIRP */ > diff --git a/savevm.c b/savevm.c > index 2ce439f..e3ad5da 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -2006,7 +2006,7 @@ static int qemu_savevm_state(QEMUFile *f) > return ret; > } > > -static int qemu_save_device_state(QEMUFile *f) > +int qemu_save_device_state(QEMUFile *f) > { > SaveStateEntry *se; > > -- > 1.7.7.6