From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uc0G1-000097-Mt for qemu-devel@nongnu.org; Mon, 13 May 2013 17:26:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uc0G0-0001wz-M9 for qemu-devel@nongnu.org; Mon, 13 May 2013 17:26:09 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:33551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uc0G0-0001wS-3r for qemu-devel@nongnu.org; Mon, 13 May 2013 17:26:08 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 May 2013 07:20:39 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 103612CE804A for ; Tue, 14 May 2013 07:25:58 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4DLBoJZ19988704 for ; Tue, 14 May 2013 07:11:50 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4DLPuLV025313 for ; Tue, 14 May 2013 07:25:57 +1000 From: Anthony Liguori In-Reply-To: <20130507124958.GA21660@redhat.com> References: <20130507124958.GA21660@redhat.com> Date: Mon, 13 May 2013 16:25:44 -0500 Message-ID: <87bo8etvvr.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCHv3 for-1.5] virtio-pci: fix level interrupts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , KONRAD Frederic "Michael S. Tsirkin" writes: > mask notifiers are never called without msix, > so devices with backend masking like vhost don't work. > Call mask notifiers explicitly at > startup/cleanup to make it work. > > Signed-off-by: Michael S. Tsirkin > Tested-by: Alexander Graf Applied, thanks. There was no notification email because I applied it by hand because the subject is not well formed. Regards, Anthony Liguori > --- > > changes from v2: > fix bug spotted by Konrad > changes from v1: > rebased to master > > I'm guessing this missed 1.5. Added for-1.5 just in > case - probably should go into 1.5.1. > > hw/virtio/virtio-pci.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index d8708c1..195ee04 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c > @@ -744,6 +744,7 @@ static int virtio_pci_set_guest_notifier(DeviceState *d, int n, bool assign, > bool with_irqfd) > { > VirtIOPCIProxy *proxy = to_virtio_pci_proxy(d); > + VirtioDeviceClass *vdc = VIRTIO_DEVICE_GET_CLASS(proxy->vdev); > VirtQueue *vq = virtio_get_queue(proxy->vdev, n); > EventNotifier *notifier = virtio_queue_get_guest_notifier(vq); > > @@ -758,6 +759,10 @@ static int virtio_pci_set_guest_notifier(DeviceState *d, int n, bool assign, > event_notifier_cleanup(notifier); > } > > + if (!msix_enabled(&proxy->pci_dev) && vdc->guest_notifier_mask) { > + vdc->guest_notifier_mask(proxy->vdev, n, !assign); > + } > + > return 0; > } > > -- > MST