From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34969)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UVT2T-0002gl-Bo
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 16:45:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UVT2S-0000bT-D1
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 16:45:09 -0400
Received: from mail-oa0-f52.google.com ([209.85.219.52]:46164)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UVT2R-0000au-VQ
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 16:45:08 -0400
Received: by mail-oa0-f52.google.com with SMTP id n12so3344399oag.11
	for <qemu-devel@nongnu.org>; Thu, 25 Apr 2013 13:45:07 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <20130425201106.GG11821@otherpad.lan.raisama.net>
References: <1366316544-1428-1-git-send-email-lersek@redhat.com>
	<1366316544-1428-8-git-send-email-lersek@redhat.com>
	<87li86xwk6.fsf@codemonkey.ws>
	<20130425201106.GG11821@otherpad.lan.raisama.net>
Date: Thu, 25 Apr 2013 15:45:04 -0500
Message-ID: <87bo928hm7.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for
	fw_cfg clients
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org, mst@redhat.com

Eduardo Habkost <ehabkost@redhat.com> writes:

> On Thu, Apr 25, 2013 at 02:03:05PM -0500, Anthony Liguori wrote:
>> Laszlo Ersek <lersek@redhat.com> writes:
>> > --- /dev/null
>> > +++ b/hw/i386/acpi.h
>> > +
>> > +#include <stddef.h>
>> 
>> QEMU style would normally be to use qemu-common.h here but honestly I
>> prefer using system headers when it's possible.  Just FYI.
>
> I thought we were actively trying to stop including qemu-common.h from
> other header files, because it easily leads to unexpected (and hard to
> fix) circular header dependencies.

The problem is qemu-common including other headers, not other headers
including qemu-common...

But like I said in my original note, I don't like using qemu-common in
headers anyway.

Regards,

Anthony Liguori

>
> -- 
> Eduardo