From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UN3V9-00081S-Lb for qemu-devel@nongnu.org; Tue, 02 Apr 2013 11:52:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UN3V3-0005R5-Ss for qemu-devel@nongnu.org; Tue, 02 Apr 2013 11:51:59 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:60814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UN3V3-0005AQ-Bj for qemu-devel@nongnu.org; Tue, 02 Apr 2013 11:51:53 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Apr 2013 01:42:23 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id AF83A2CE804C for ; Wed, 3 Apr 2013 02:50:52 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r32FolLL7471562 for ; Wed, 3 Apr 2013 02:50:47 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r32Foqku022414 for ; Wed, 3 Apr 2013 02:50:52 +1100 From: Anthony Liguori In-Reply-To: <20130402104547.1bf2cfc6@redhat.com> References: <1364409987-23742-1-git-send-email-lcapitulino@redhat.com> <1364409987-23742-7-git-send-email-lcapitulino@redhat.com> <87fvzai7qx.fsf@codemonkey.ws> <20130402103701.4c1cce5d@redhat.com> <20130402104547.1bf2cfc6@redhat.com> Date: Tue, 02 Apr 2013 10:50:49 -0500 Message-ID: <87bo9x53ty.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org Luiz Capitulino writes: > On Tue, 2 Apr 2013 10:37:01 -0400 > Luiz Capitulino wrote: > >> On Mon, 01 Apr 2013 10:35:34 -0500 >> Anthony Liguori wrote: >> >> > Luiz Capitulino writes: >> > >> > > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() >> > > to retry on qemu_chr_fe_write() errors. However, the Monitor's output >> > > buffer can keep growing while the retry is not issued and this can >> > > cause the buffer to overflow. >> > > >> > > To reproduce this issue, just start qemu and type on the Monitor: >> > > >> > > (qemu) ? >> > > >> > > This will cause the assertion to trig. >> > > >> > > To fix this problem this commit makes the Monitor buffer dynamic, >> > > which means that it can grow as much as needed. >> > > >> > > Signed-off-by: Luiz Capitulino >> > >> > This breaks hotplug according to git bisect. The test output is: >> >> I'm trying to reproduce this w/o qemu-test as you suggested on irc, but >> what I'm getting is: >> >> # ./qemu-qmp -enable-kvm -qmp unix:./qmp-sock,server,nowait -monitor stdio >> QEMU 1.4.50 monitor - type 'help' for more information >> (qemu) device_add virtio-blk-pci,drive=hd0 >> Property 'virtio-blk-pci.drive' can't find value 'hd0' >> ** >> ERROR:/home/lcapitulino/work/src/upstream/qmp-unstable/qom/object.c:1003:object_get_canonical_path: assertion failed: (obj->parent != NULL) >> >> Also happens on master, so I'll bisect that one first... > > I was obviously missing a drive_add first, but the assertion is a bug > anyway. I've got a patch waiting to be pushed that fixes the assert. Regards, Anthony Liguori