From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJMp-00080q-5W for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:32:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsJMo-00045X-1J for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:32:19 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:36569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJMn-00045I-S0 for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:32:17 -0500 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Jan 2013 15:32:17 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 317576E803C for ; Mon, 7 Jan 2013 15:32:00 -0500 (EST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r07KVtLo286384 for ; Mon, 7 Jan 2013 15:31:56 -0500 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r07KVsxb026562 for ; Mon, 7 Jan 2013 13:31:54 -0700 From: Anthony Liguori In-Reply-To: <1354740282-20679-1-git-send-email-pbonzini@redhat.com> References: <1354740282-20679-1-git-send-email-pbonzini@redhat.com> Date: Mon, 07 Jan 2013 14:31:48 -0600 Message-ID: <87bod0g2ff.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 00/11] qdev: correct reference counting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: afaerber@suse.de Paolo Bonzini writes: > This series makes the ref_count field of device and bus objects actually > match the number of references that the objects have. Once this is done, > qdev_free and qbus_free are equivalent to simply object_unparent, and > object_delete can go. > > Patches 1-3 fix some warts in the last minute patches that went in 1.3. > Patches 4-9 are the bulk of the series. Patches 10-11 touches the CPU > classes instead. Other than the few minor comments: Reviewed-by: Anthony Liguori Thanks for spending time on this. It's a PITA to get right. Regards, Anthony Liguori > > Paolo > > Paolo Bonzini (11): > qdev: export and use qbus_init > qdev: use object_new, not g_malloc to create buses > qom: preserve object while unparenting it > qdev: add reference count to a device for the BusChild > qdev: move deletion of children from finalize to unparent > qdev: move unrealization of devices from finalize to unparent > qdev: add reference for the bus while it is referred to by the > DeviceState > qdev: inline object_delete into qbus_free/qdev_free > qdev: drop extra references at creation time > cpu: do not use object_delete > qom: remove object_delete > > hw/pci.c | 11 +++--- > hw/pci.h | 5 --- > hw/qdev-core.h | 1 + > hw/qdev-monitor.c | 5 ++- > hw/qdev.c | 107 +++++++++++++++++++++++++++++--------------------- > hw/sysbus.c | 6 +-- > include/qemu/object.h | 17 +------- > linux-user/syscall.c | 2 +- > qom/object.c | 9 +---- > target-i386/helper.c | 4 +- > target-sparc/cpu.c | 2 +- > vl.c | 1 + > 12 files changed, 84 insertions(+), 86 deletions(-) > > -- > 1.8.0.1