Re: [Qemu-devel] [PULL 0/4] test and debug devices

[Anthony Liguori <anthony@codemonkey.ws>]

Gerd Hoffmann <kraxel@redhat.com> writes:

>   Hi,
>
>>> This patch series improves the debug devices we have.  isa-debugcon is
>>> switched over to the memory api.  isa-debug-exit is added and replaces
>>> the hard-coded bochs debug port.  pc-testdev (used by kvm-unit-tests) is
>>> added.
>> 
>> Missing some CCs, and I was actually expecting another PATCH series
>> first... as brought up before it is refreshing an uncommitted series by
>> Hervé without any mention thereof in the commit message
>
> Hmm?  The isa-debug-exit patch is written by myself.  After hacking it
> up I've noticed Herve wrote a simliar one.  But I didn't grab Herve's
> patch.  I've picked up + updated Lucas' testdev patch, and that is
> clearly visible in the commit message.
>
>> and I thought
>> there was an unanswered question to Anthony on both Lucas' and Hervé's
>> series?
>
> The only outstanding question I'm aware of is whenever anthony does a
> outb or outw on the bochs debug port in his test suite.

outb.

Regards,

Anthony Liguori

> My
> isa-debug-exit device handles both cases, so we should be fine here, and
> I'm sure Anthony will actually try before committing the series ;)
>
> What else is unanswered?
>
> cheers,
>   Gerd