From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TeBPn-0005Ew-TJ
	for qemu-devel@nongnu.org; Thu, 29 Nov 2012 16:13:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TeBPm-0005bu-MM
	for qemu-devel@nongnu.org; Thu, 29 Nov 2012 16:12:59 -0500
Received: from mail-ie0-f173.google.com ([209.85.223.173]:54903)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TeBPm-0005bl-HL
	for qemu-devel@nongnu.org; Thu, 29 Nov 2012 16:12:58 -0500
Received: by mail-ie0-f173.google.com with SMTP id e13so12073987iej.4
	for <qemu-devel@nongnu.org>; Thu, 29 Nov 2012 13:12:58 -0800 (PST)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <50B7BA3D.5010600@redhat.com>
References: <2093724096.16404973.1354216910353.JavaMail.root@redhat.com>
	<9FB55746-DDB0-4E07-BF8D-46CC7A61A2F3@suse.de>
	<50B7BA3D.5010600@redhat.com>
Date: Thu, 29 Nov 2012 15:12:53 -0600
Message-ID: <87boeg6rl6.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il 29/11/2012 20:24, Alexander Graf ha scritto:
>>> > It is in hw/multiboot.c:
>>> > 
>>> >    stl_p(bootinfo + MBI_MEM_LOWER,   640);
>> You want to remove that one then.
>
> I wasn't sure of what happens if the multiboot option ROM is old.  Do we
> support that to any extent?

Option ROMs are migrated but reset after reboot.  I guess you could
migrate before the option ROM is executed but that seems extraordinarily
unlikely.

Regards,

Anthony Liguori

>
>> > Regarding the testcase, Xen will touch the EBDA without this patch and
>> > with http://permalink.gmane.org/gmane.comp.emulators.xen.devel/144855.
>> > However, SeaBIOS does not complain.
>>
>> I see :). Well, the patch is unintrusive enough for be ok for 1.3 IMHO.
>
> Actually it's relatively easy to see a failure with Xen and a need to
> PCI passthrough something with a bulky boot ROM; iSCSI or FC cards will
> do.  You'll need both the Xen patch above, and this patch to boot
> successfully.  Otherwise, it will fail to boot.
>
> Paolo