From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40266)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1SwGMP-0002Ub-Ak
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 13:35:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1SwGMO-0002ny-3y
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 13:35:57 -0400
Received: from e28smtp07.in.ibm.com ([122.248.162.7]:36778)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1SwGMN-0002nb-GA
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 13:35:56 -0400
Received: from /spool/local
	by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aneesh.kumar@linux.vnet.ibm.com>;
	Tue, 31 Jul 2012 23:05:44 +0530
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q6VHZft216449574
	for <qemu-devel@nongnu.org>; Tue, 31 Jul 2012 23:05:41 +0530
Received: from d28av04.in.ibm.com (loopback [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q6VHZfFx017695
	for <qemu-devel@nongnu.org>; Wed, 1 Aug 2012 03:35:41 +1000
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <501808CB.9090009@weilnetz.de>
References: <1343648493-27905-1-git-send-email-avi@redhat.com>
	<877gtks9qc.fsf@skywalker.in.ibm.com>
	<501808CB.9090009@weilnetz.de>
Date: Tue, 31 Jul 2012 23:05:35 +0530
Message-ID: <87boivkf4o.fsf@skywalker.in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] configure: fix libcap detection
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, rjones@redhat.com, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

Stefan Weil <sw@weilnetz.de> writes:

> Am 31.07.2012 08:52, schrieb Aneesh Kumar K.V:
>> Avi Kivity <avi@redhat.com> writes:
>>
>>>   - avoid assigned-but-not-used error
>>>   - avoid missing return error
>>>
>>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>
>> Acked-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>>
>> 	
>>> ---
>>>   configure | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 7767aca..5fb449d 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2099,7 +2099,7 @@ if test "$cap" != "no" ; then
>>>     cat > $TMPC <<EOF
>>>   #include <stdio.h>
>>>   #include <sys/capability.h>
>>> -int main(void) { cap_t caps; caps = cap_init(); }
>>> +int main(void) { cap_t caps; caps = cap_init(); (void)caps; return 0; }
>>>   EOF
>>>     if compile_prog "" "-lcap" ; then
>>>       cap=yes
>>> -- 
>>> 1.7.11.3
>
>
> Hi Anthony,
>
> please apply http://patchwork.ozlabs.org/patch/171067/,
> or we'll get a 4th bug fix for this.

I sent a pull request for VirtFS taking the patch done by you
found at

http://patchwork.ozlabs.org/patch/171704/ 

That patch is important for VirtFS because without that VirtFS won't
be enabled in the build.

Let me know if you want me to redo the pull request.

-aneesh