From: Juan Quintela <quintela@redhat.com>
To: "(Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
Cc: Orit Wasserman <owasserm@redhat.com>,
chegu_vinod@hp.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/7] Exit loop if we have been there too long
Date: Fri, 22 Jun 2012 14:44:16 +0200 [thread overview]
Message-ID: <87bokbectb.fsf@elfo.mitica> (raw)
In-Reply-To: <20120622024204.GB53903@cs.nctu.edu.tw> ("陳韋任 (Wei-Ren Chen)"'s message of "Fri, 22 Jun 2012 10:42:04 +0800")
"(Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw> wrote:
>> >> + if ((i & 63) == 0) {
>> >> + uint64_t t1 = (qemu_get_clock_ns(rt_clock) - bwidth) / 1000000;
>> >> + if (t1 > 50) { /* 50ms, half buffered_file limit */
>> > can't we use a constant ?
>>
>> 50 is a constant already, no? Or what do you mean.
>
> I guess Orit means,
>
> #define THRESHOLD 50
>
> if (t1 > THRESHOLD) { ... }
Thanks, Added.
Later, Juan.
next prev parent reply other threads:[~2012-06-22 12:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 18:32 [Qemu-devel] [RFC 0/7] Fix migration with lots of memory Juan Quintela
2012-05-22 18:32 ` [Qemu-devel] [PATCH 1/7] Add spent time for migration Juan Quintela
2012-06-14 10:52 ` Orit Wasserman
2012-05-22 18:32 ` [Qemu-devel] [PATCH 2/7] Add tracepoints for savevm section start/end Juan Quintela
2012-06-14 11:00 ` Orit Wasserman
2012-05-22 18:32 ` [Qemu-devel] [PATCH 3/7] No need to iterate if we already are over the limit Juan Quintela
2012-06-14 11:03 ` Orit Wasserman
2012-05-22 18:32 ` [Qemu-devel] [PATCH 4/7] Only TCG needs TLB handling Juan Quintela
2012-06-14 11:15 ` Orit Wasserman
2012-05-22 18:32 ` [Qemu-devel] [PATCH 5/7] Only calculate expected_time for stage 2 Juan Quintela
2012-06-14 11:31 ` Orit Wasserman
2012-05-22 18:32 ` [Qemu-devel] [PATCH 6/7] Exit loop if we have been there too long Juan Quintela
2012-06-14 11:36 ` Orit Wasserman
2012-06-21 19:34 ` Juan Quintela
2012-06-22 2:42 ` 陳韋任 (Wei-Ren Chen)
2012-06-22 12:44 ` Juan Quintela [this message]
2012-05-22 18:32 ` [Qemu-devel] [PATCH 7/7] Maintaing number of dirty pages Juan Quintela
2012-06-14 11:42 ` Orit Wasserman
2012-06-11 3:56 ` [Qemu-devel] [RFC 0/7] Fix migration with lots of memory Chegu Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bokbectb.fsf@elfo.mitica \
--to=quintela@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=chenwj@iis.sinica.edu.tw \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).