From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58146)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Si3EK-0005W8-1X
	for qemu-devel@nongnu.org; Fri, 22 Jun 2012 08:44:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Si3ED-0006G5-J0
	for qemu-devel@nongnu.org; Fri, 22 Jun 2012 08:44:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29007)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Si3ED-0006G0-As
	for qemu-devel@nongnu.org; Fri, 22 Jun 2012 08:44:45 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20120622024204.GB53903@cs.nctu.edu.tw> (=?utf-8?B?IumZsw==?=
	=?utf-8?B?6Z+L5Lu7?= (Wei-Ren
	Chen)"'s message of "Fri, 22 Jun 2012 10:42:04 +0800")
References: <cover.1337710679.git.quintela@redhat.com>
	<189d97ce396dd1b4e8b497fbd1b276086ac05cbc.1337710679.git.quintela@redhat.com>
	<4FD9CCD7.3030407@redhat.com> <87fw9o4fy1.fsf@elfo.mitica>
	<20120622024204.GB53903@cs.nctu.edu.tw>
Date: Fri, 22 Jun 2012 14:44:16 +0200
Message-ID: <87bokbectb.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 6/7] Exit loop if we have been there too
	long
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "(Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
Cc: Orit Wasserman <owasserm@redhat.com>, chegu_vinod@hp.com, qemu-devel@nongnu.org

"(Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw> wrote:
>> >> +        if ((i & 63) == 0) {
>> >> +            uint64_t t1 = (qemu_get_clock_ns(rt_clock) - bwidth) / 1000000;
>> >> +            if (t1 > 50) { /* 50ms, half buffered_file limit */
>> > can't we use a constant ?
>> 
>> 50 is a constant already, no?  Or what do you mean.
>
>   I guess Orit means,
>
> #define THRESHOLD 50
>
> if (t1 > THRESHOLD) { ... }

Thanks, Added.

Later, Juan.