From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDA03FCC9C8 for ; Tue, 10 Mar 2026 06:46:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzqrB-0004fd-PO; Tue, 10 Mar 2026 02:46:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzqr8-0004fM-Bi for qemu-devel@nongnu.org; Tue, 10 Mar 2026 02:46:15 -0400 Received: from outbound1.eu.mailhop.org ([52.28.251.132]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzqr5-0005CN-QB for qemu-devel@nongnu.org; Tue, 10 Mar 2026 02:46:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stackframe.org; s=duo-1634547266507-560c42ae; h=content-transfer-encoding:content-type:mime-version:message-id:date: references:in-reply-to:subject:cc:to:from:cfbl-address:cfbl-feedback-id:from; bh=8OnvBWgowL4v1FqA/byhJ4sp72F7sGmVR565J1dcvRo=; b=YMT4k0Xx7Dd+VEpiduJ8vofzMbnrGZdcDn7NojkOOwTcfSanXBbyNQT+slGTAUZ5GJxQm0KYQWiXH r0Y64sU3FOiMVW1oh5QBbMnCawPD5XCMfHDUDQBTgxKh1haNEvbpP6KS10Qop899/z7OKfWqycukGd MkR4d5iOnQijIRLY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:content-type:mime-version:message-id:date: references:in-reply-to:subject:cc:to:from:cfbl-address:cfbl-feedback-id:from; bh=8OnvBWgowL4v1FqA/byhJ4sp72F7sGmVR565J1dcvRo=; b=GQE/ggTh2vobRNBdzVVdd7uoFuiSaGDNS5vWpoL3l60SCXvh8e6uLgEVFa50BkSY88kAFavYpUPz7 Tm3ga43DRUo85iyjSXAbpayQVaCelkwhioH9uD3SihgP2L5Ft3tUvoGXfvlUnmldtdu4mDezeithRu drJLrdvqoDJIt54viZjWxUHys7+iKYj8/mSAYJ99f6IM8ksr8EnXCnBC+CrQuupQuqEbyJHBuxXOYM iU7B6XTg3b7CjZmISdEnisGTftsb9qNLd0B7PFWauQBCViMeTeROPXpkUb/hkhyNtBjGjIey6WKZye DcJj+rdwRyRIzGrM6cOWNBJ22kZcszA== X-Originating-IP: 130.180.31.158 X-MHO-RoutePath: dG9ta2lzdG5lcm51 X-MHO-User: ccef5dce-1c4c-11f1-83f1-f54febe22707 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP CFBL-Feedback-ID: ccef5dce-1c4c-11f1-83f1-f54febe22707:13 CFBL-Address: prvs=0529f992e2=abuse@outbound.mailhop.org; report=arf Received: from mail.duncanthrax.net (mail.duncanthrax.net [130.180.31.158]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id ccef5dce-1c4c-11f1-83f1-f54febe22707; Tue, 10 Mar 2026 06:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stackframe.org; s=dkim1; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8OnvBWgowL4v1FqA/byhJ4sp72F7sGmVR565J1dcvRo=; b=dq5gAwIu9dKAUwqTV4buPHssgp qR1fZXsCEx6zOlV0NF2cE6CLp91YuUXR72VlS9JYCsudXc61lGUYq7wrEckPZEidoYJvuL5ijEPdW 9ZoFmqE9jyI2kAXPWbI7t1kMHPgKKOMV/mUqQl6ixaTD2ZokHNXHzKcGOpEVHqhb8pjCXiJFVBTqw RHHTAuYDLZlS+RkHASNIWaCLy0objIVRUhTSWoogmu8gYhiOFKECqige9DQyEPBISWcvGjaP/NK/5 6slKX+aZ/Dg0CFRu84xTQYA9rKBOPZCaEhQOIMoJMZja8jKq9Q+qFNxr1zSBtrnzS9knWRW8VTRZY GxNwa9aw==; Received: from [134.3.93.166] (helo=t14.stackframe.org) by mail.duncanthrax.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97) (envelope-from ) id 1vzqqu-0000000AxaW-20SO; Tue, 10 Mar 2026 07:46:00 +0100 From: Sven Schnelle To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: deller@kernel.org, qemu-devel@nongnu.org, Soumyajyotii Ssarkar , Paolo Bonzini , Helge Deller , Richard Henderson , Fam Zheng Subject: Re: [PULL 12/12] target/hppa: add 64 bit support to gdbstub In-Reply-To: <52cbaf6d-f7a4-4984-9561-ca31418cdc0f@linaro.org> References: <20251223155031.7110-1-deller@kernel.org> <20251223155031.7110-13-deller@kernel.org> <52cbaf6d-f7a4-4984-9561-ca31418cdc0f@linaro.org> Date: Tue, 10 Mar 2026 07:45:59 +0100 Message-ID: <87cy1cb2s8.fsf@stackframe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=52.28.251.132; envelope-from=svens@stackframe.org; helo=outbound1.eu.mailhop.org X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > Hi, > > (now merged as commit b2c2d00f48cc5f4486cfba33b505ff86d79cb137) > > On 23/12/25 16:50, deller@kernel.org wrote: >> From: Sven Schnelle >> Signed-off-by: Sven Schnelle >> Reviewed-by: Helge Deller >> Reviewed-by: Philippe Mathieu-Daud=C3=A9 >> Signed-off-by: Helge Deller >> --- >> target/hppa/gdbstub.c | 62 > ++++++++++++++++++++++++++++--------------- >> 1 file changed, 41 insertions(+), 21 deletions(-) >> diff --git a/target/hppa/gdbstub.c b/target/hppa/gdbstub.c >> index 0daa52f7af..777f4a48b9 100644 >> --- a/target/hppa/gdbstub.c >> +++ b/target/hppa/gdbstub.c >> @@ -21,16 +21,25 @@ >> @@ -133,24 +142,35 @@ int hppa_cpu_gdb_read_register(CPUState *cs, > GByteArray *mem_buf, int n) >> val =3D env->cr[30]; >> break; >> case 64 ... 127: >> - val =3D extract64(env->fr[(n - 64) / 2], (n & 1 ? 0 : 32), 32); >> - break; >> - default: >> - if (n < 128) { >> - val =3D 0; >> + if (hppa_is_pa20(env)) { >> + val =3D env->fr[n - 64]; > > Coverity reports: > >>>> CID 1645613: Memory - illegal accesses (OVERRUN) >>>> Overrunning array "env->fr" of 32 8-byte elements at element > index 32 (byte offset 263) using index "n - 64" (which > evaluates to 32). Yes, there's indeed a check missing wether n is < 96. I'll submit a patch l= ater.