* [PATCH] migration: HMP: Adjust the order of output fields
@ 2025-09-29 2:12 Bin Guo
2025-09-29 14:12 ` Peter Xu
2025-09-29 14:25 ` Fabiano Rosas
0 siblings, 2 replies; 4+ messages in thread
From: Bin Guo @ 2025-09-29 2:12 UTC (permalink / raw)
To: qemu-devel; +Cc: peterx, farosas
Adjust the positions of 'tls-authz' and 'max-postcopy-bandwidth' in
the fields output by the 'info migrate_parameters' command so that
related fields are next to each other.
For clarity only, no functional changes.
Sample output after this commit:
(qemu) info migrate_parameters
...
max-cpu-throttle: 99
tls-creds: ''
tls-hostname: ''
tls-authz: ''
max-bandwidth: 134217728 bytes/second
avail-switchover-bandwidth: 0 bytes/second
max-postcopy-bandwidth: 0 bytes/second
downtime-limit: 300 ms
...
Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
---
migration/migration-hmp-cmds.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index 0fc21f0647..814221b260 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -353,6 +353,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
monitor_printf(mon, "%s: '%s'\n",
MigrationParameter_str(MIGRATION_PARAMETER_TLS_HOSTNAME),
params->tls_hostname);
+ assert(params->tls_authz);
+ monitor_printf(mon, "%s: '%s'\n",
+ MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
+ params->tls_authz);
assert(params->has_max_bandwidth);
monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH),
@@ -361,6 +365,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
MigrationParameter_str(MIGRATION_PARAMETER_AVAIL_SWITCHOVER_BANDWIDTH),
params->avail_switchover_bandwidth);
+ assert(params->has_max_postcopy_bandwidth);
+ monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
+ MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH),
+ params->max_postcopy_bandwidth);
assert(params->has_downtime_limit);
monitor_printf(mon, "%s: %" PRIu64 " ms\n",
MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT),
@@ -383,12 +391,6 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
monitor_printf(mon, "%s: %" PRIu64 " bytes\n",
MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE),
params->xbzrle_cache_size);
- monitor_printf(mon, "%s: %" PRIu64 "\n",
- MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH),
- params->max_postcopy_bandwidth);
- monitor_printf(mon, "%s: '%s'\n",
- MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
- params->tls_authz);
if (params->has_block_bitmap_mapping) {
const BitmapMigrationNodeAliasList *bmnal;
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] migration: HMP: Adjust the order of output fields
2025-09-29 2:12 [PATCH] migration: HMP: Adjust the order of output fields Bin Guo
@ 2025-09-29 14:12 ` Peter Xu
2025-09-29 15:29 ` Peter Xu
2025-09-29 14:25 ` Fabiano Rosas
1 sibling, 1 reply; 4+ messages in thread
From: Peter Xu @ 2025-09-29 14:12 UTC (permalink / raw)
To: Bin Guo; +Cc: qemu-devel, farosas
On Mon, Sep 29, 2025 at 10:12:13AM +0800, Bin Guo wrote:
> Adjust the positions of 'tls-authz' and 'max-postcopy-bandwidth' in
> the fields output by the 'info migrate_parameters' command so that
> related fields are next to each other.
>
> For clarity only, no functional changes.
>
> Sample output after this commit:
> (qemu) info migrate_parameters
> ...
> max-cpu-throttle: 99
> tls-creds: ''
> tls-hostname: ''
> tls-authz: ''
> max-bandwidth: 134217728 bytes/second
> avail-switchover-bandwidth: 0 bytes/second
> max-postcopy-bandwidth: 0 bytes/second
This can be moved even above "avail-switchover-bandwidth", IMHO.
With that, feel free to take:
Reviewed-by: Peter Xu <peterx@redhat.com>
> downtime-limit: 300 ms
> ...
>
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
> ---
> migration/migration-hmp-cmds.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
> index 0fc21f0647..814221b260 100644
> --- a/migration/migration-hmp-cmds.c
> +++ b/migration/migration-hmp-cmds.c
> @@ -353,6 +353,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, "%s: '%s'\n",
> MigrationParameter_str(MIGRATION_PARAMETER_TLS_HOSTNAME),
> params->tls_hostname);
> + assert(params->tls_authz);
> + monitor_printf(mon, "%s: '%s'\n",
> + MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
> + params->tls_authz);
> assert(params->has_max_bandwidth);
> monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
> MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH),
> @@ -361,6 +365,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
> MigrationParameter_str(MIGRATION_PARAMETER_AVAIL_SWITCHOVER_BANDWIDTH),
> params->avail_switchover_bandwidth);
> + assert(params->has_max_postcopy_bandwidth);
> + monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n",
> + MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH),
> + params->max_postcopy_bandwidth);
> assert(params->has_downtime_limit);
> monitor_printf(mon, "%s: %" PRIu64 " ms\n",
> MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT),
> @@ -383,12 +391,6 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, "%s: %" PRIu64 " bytes\n",
> MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE),
> params->xbzrle_cache_size);
> - monitor_printf(mon, "%s: %" PRIu64 "\n",
> - MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH),
> - params->max_postcopy_bandwidth);
> - monitor_printf(mon, "%s: '%s'\n",
> - MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
> - params->tls_authz);
>
> if (params->has_block_bitmap_mapping) {
> const BitmapMigrationNodeAliasList *bmnal;
> --
> 2.39.5
>
>
--
Peter Xu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] migration: HMP: Adjust the order of output fields
2025-09-29 2:12 [PATCH] migration: HMP: Adjust the order of output fields Bin Guo
2025-09-29 14:12 ` Peter Xu
@ 2025-09-29 14:25 ` Fabiano Rosas
1 sibling, 0 replies; 4+ messages in thread
From: Fabiano Rosas @ 2025-09-29 14:25 UTC (permalink / raw)
To: Bin Guo, qemu-devel; +Cc: peterx
Bin Guo <guobin@linux.alibaba.com> writes:
> Adjust the positions of 'tls-authz' and 'max-postcopy-bandwidth' in
> the fields output by the 'info migrate_parameters' command so that
> related fields are next to each other.
>
> For clarity only, no functional changes.
>
> Sample output after this commit:
> (qemu) info migrate_parameters
> ...
> max-cpu-throttle: 99
> tls-creds: ''
> tls-hostname: ''
> tls-authz: ''
> max-bandwidth: 134217728 bytes/second
> avail-switchover-bandwidth: 0 bytes/second
> max-postcopy-bandwidth: 0 bytes/second
> downtime-limit: 300 ms
> ...
>
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] migration: HMP: Adjust the order of output fields
2025-09-29 14:12 ` Peter Xu
@ 2025-09-29 15:29 ` Peter Xu
0 siblings, 0 replies; 4+ messages in thread
From: Peter Xu @ 2025-09-29 15:29 UTC (permalink / raw)
To: Bin Guo; +Cc: qemu-devel, farosas
On Mon, Sep 29, 2025 at 10:12:50AM -0400, Peter Xu wrote:
> On Mon, Sep 29, 2025 at 10:12:13AM +0800, Bin Guo wrote:
> > Adjust the positions of 'tls-authz' and 'max-postcopy-bandwidth' in
> > the fields output by the 'info migrate_parameters' command so that
> > related fields are next to each other.
> >
> > For clarity only, no functional changes.
> >
> > Sample output after this commit:
> > (qemu) info migrate_parameters
> > ...
> > max-cpu-throttle: 99
> > tls-creds: ''
> > tls-hostname: ''
> > tls-authz: ''
> > max-bandwidth: 134217728 bytes/second
> > avail-switchover-bandwidth: 0 bytes/second
> > max-postcopy-bandwidth: 0 bytes/second
>
> This can be moved even above "avail-switchover-bandwidth", IMHO.
I queued it with this change, please shoot if there's objections.
Thanks,
--
Peter Xu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-29 15:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-29 2:12 [PATCH] migration: HMP: Adjust the order of output fields Bin Guo
2025-09-29 14:12 ` Peter Xu
2025-09-29 15:29 ` Peter Xu
2025-09-29 14:25 ` Fabiano Rosas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).