qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags
@ 2025-09-16 16:30 Peter Maydell
  2025-09-16 16:39 ` Daniel P. Berrangé
  2025-09-16 17:45 ` Alex Bennée
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2025-09-16 16:30 UTC (permalink / raw)
  To: qemu-devel; +Cc: Daniel P. Berrangé

In commit 52a21689cd829 we added a workaround for a bug in older
versions of htags where they fail with a weird error message if the
environment is too large.  However, we missed one variable which
gitlab CI can set to the body of the commit message:
CI_COMMIT_DESCRIPTION.

Add this to the variables we unset when running htags, so that
the 'pages' job doesn't fail if the most recent commit happens
to have a very large commit message.

Cc: qemu-stable@nongnu.org
Fixes: 52a21689cd8 (".gitlab-ci.d/buildtest.yml: Work around htags bug when environment is large")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 .gitlab-ci.d/buildtest.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index d888a600637..37a53bf105d 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -736,7 +736,7 @@ pages:
     - make gtags
     # We unset variables to work around a bug in some htags versions
     # which causes it to fail when the environment is large
-    - CI_COMMIT_MESSAGE= CI_COMMIT_TAG_MESSAGE= htags
+    - CI_COMMIT_MESSAGE= CI_COMMIT_TAG_MESSAGE= CI_COMMIT_DESCRIPTION= htags
         -anT --tree-view=filetree -m qemu_init
         -t "Welcome to the QEMU sourcecode"
     - mv HTML public/src
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags
  2025-09-16 16:30 [PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags Peter Maydell
@ 2025-09-16 16:39 ` Daniel P. Berrangé
  2025-09-16 17:45 ` Alex Bennée
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2025-09-16 16:39 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-devel

On Tue, Sep 16, 2025 at 05:30:30PM +0100, Peter Maydell wrote:
> In commit 52a21689cd829 we added a workaround for a bug in older
> versions of htags where they fail with a weird error message if the
> environment is too large.  However, we missed one variable which
> gitlab CI can set to the body of the commit message:
> CI_COMMIT_DESCRIPTION.
> 
> Add this to the variables we unset when running htags, so that
> the 'pages' job doesn't fail if the most recent commit happens
> to have a very large commit message.
> 
> Cc: qemu-stable@nongnu.org
> Fixes: 52a21689cd8 (".gitlab-ci.d/buildtest.yml: Work around htags bug when environment is large")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  .gitlab-ci.d/buildtest.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags
  2025-09-16 16:30 [PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags Peter Maydell
  2025-09-16 16:39 ` Daniel P. Berrangé
@ 2025-09-16 17:45 ` Alex Bennée
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2025-09-16 17:45 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-devel, Daniel P. Berrangé

Peter Maydell <peter.maydell@linaro.org> writes:

> In commit 52a21689cd829 we added a workaround for a bug in older
> versions of htags where they fail with a weird error message if the
> environment is too large.  However, we missed one variable which
> gitlab CI can set to the body of the commit message:
> CI_COMMIT_DESCRIPTION.
>
> Add this to the variables we unset when running htags, so that
> the 'pages' job doesn't fail if the most recent commit happens
> to have a very large commit message.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 52a21689cd8 (".gitlab-ci.d/buildtest.yml: Work around htags bug when environment is large")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-16 17:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-16 16:30 [PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags Peter Maydell
2025-09-16 16:39 ` Daniel P. Berrangé
2025-09-16 17:45 ` Alex Bennée

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).