Re: [PATCH v3 1/5] virtio-mem: Fix definition of VirtIOMEMClass

[Markus Armbruster <armbru@redhat.com>]

Zhenzhong Duan <zhenzhong.duan@intel.com> writes:

> Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice.
>
> Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/hw/virtio/virtio-mem.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/virtio/virtio-mem.h b/include/hw/virtio/virtio-mem.h
> index bc4f787772..e0ab31b45a 100644
> --- a/include/hw/virtio/virtio-mem.h
> +++ b/include/hw/virtio/virtio-mem.h
> @@ -134,7 +134,7 @@ struct VirtioMemSystemReset {
>  
>  struct VirtIOMEMClass {
>      /* private */
> -    VirtIODevice parent;
> +    VirtioDeviceClass parent_class;
>  
>      /* public */
>      void (*fill_device_info)(const VirtIOMEM *vmen, VirtioMEMDeviceInfo *vi);

*Ouch*

I guess this isn't catastrophic only because sizeof(VirtIODevice) >
sizeof(VirtioDeviceClass).  Suggest to mention that in the commit
message.

Out of scope for this patch, but I'd really, really appreciate more
consistent spelling of VirtIO.