From: "Alex Bennée" <alex.bennee@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Mikhail Tyutin" <m.tyutin@yadro.com>,
"Aleksandr Anenkov" <a.anenkov@yadro.com>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Fabiano Rosas" <farosas@suse.de>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v5 6/6] plugins: Remove an extra parameter
Date: Thu, 19 Oct 2023 21:24:44 +0100 [thread overview]
Message-ID: <87cyxa8inh.fsf@linaro.org> (raw)
In-Reply-To: <20231019101030.128431-7-akihiko.odaki@daynix.com>
Akihiko Odaki <akihiko.odaki@daynix.com> writes:
> copy_call() has an unused parameter so remove it.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Queued to plugins/next, thanks.
> ---
> accel/tcg/plugin-gen.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
> index 39b3c9351f..78b331b251 100644
> --- a/accel/tcg/plugin-gen.c
> +++ b/accel/tcg/plugin-gen.c
> @@ -327,8 +327,7 @@ static TCGOp *copy_st_ptr(TCGOp **begin_op, TCGOp *op)
> return op;
> }
>
> -static TCGOp *copy_call(TCGOp **begin_op, TCGOp *op, void *empty_func,
> - void *func, int *cb_idx)
> +static TCGOp *copy_call(TCGOp **begin_op, TCGOp *op, void *func, int *cb_idx)
> {
> TCGOp *old_op;
> int func_idx;
> @@ -372,8 +371,7 @@ static TCGOp *append_udata_cb(const struct qemu_plugin_dyn_cb *cb,
> }
>
> /* call */
> - op = copy_call(&begin_op, op, HELPER(plugin_vcpu_udata_cb),
> - cb->f.vcpu_udata, cb_idx);
> + op = copy_call(&begin_op, op, cb->f.vcpu_udata, cb_idx);
>
> return op;
> }
> @@ -420,8 +418,7 @@ static TCGOp *append_mem_cb(const struct qemu_plugin_dyn_cb *cb,
>
> if (type == PLUGIN_GEN_CB_MEM) {
> /* call */
> - op = copy_call(&begin_op, op, HELPER(plugin_vcpu_mem_cb),
> - cb->f.vcpu_udata, cb_idx);
> + op = copy_call(&begin_op, op, cb->f.vcpu_udata, cb_idx);
> }
>
> return op;
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
prev parent reply other threads:[~2023-10-19 20:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 10:10 [PATCH v5 0/6] gdbstub and TCG plugin improvements Akihiko Odaki
2023-10-19 10:10 ` [PATCH v5 1/6] gdbstub: Check if gdb_regs is NULL Akihiko Odaki
2023-10-19 13:57 ` Fabiano Rosas
2023-10-19 17:59 ` Alex Bennée
2023-10-19 10:10 ` [PATCH v5 2/6] hw/riscv: Use misa_mxl instead of misa_mxl_max Akihiko Odaki
2023-10-19 10:10 ` [PATCH v5 3/6] target/riscv: Remove misa_mxl validation Akihiko Odaki
2023-10-19 10:10 ` [PATCH v5 4/6] target/riscv: Move misa_mxl_max to class Akihiko Odaki
2023-10-19 10:10 ` [PATCH v5 5/6] target/riscv: Validate misa_mxl_max only once Akihiko Odaki
2023-10-19 10:10 ` [PATCH v5 6/6] plugins: Remove an extra parameter Akihiko Odaki
2023-10-19 20:24 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyxa8inh.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=a.anenkov@yadro.com \
--cc=akihiko.odaki@daynix.com \
--cc=farosas@suse.de \
--cc=m.tyutin@yadro.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).