From: "Alex Bennée" <alex.bennee@linaro.org>
To: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Cc: philmd@linaro.org, richard.henderson@linaro.org,
danielhb413@gmail.com, lucas.araujo@eldorado.org.br,
clg@kaod.org, david@gibson.dropbear.id.au, groug@kaod.org,
qemu-ppc@nongnu.org, john_platts@hotmail.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] tcg: ppc64: Fix mask generation for vextractdm
Date: Tue, 02 May 2023 10:03:32 +0100 [thread overview]
Message-ID: <87cz3jt89i.fsf@linaro.org> (raw)
In-Reply-To: <168141245022.3026479.1619179446205380588.stgit@ltc-boston1.aus.stglabs.ibm.com>
Shivaprasad G Bhat <sbhat@linux.ibm.com> writes:
> In function do_extractm() the mask is calculated as
> dup_const(1 << (element_width - 1)). '1' being signed int
> works fine for MO_8,16,32. For MO_64, on PPC64 host
> this ends up becoming 0 on compilation. The vextractdm
> uses MO_64, and it ends up having mask as 0.
>
> Explicitly use 1ULL instead of signed int 1 like its
> used everywhere else.
>
> Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-05-02 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 19:00 [PATCH 0/2] tcg: ppc64: Fix mask generation for vextractdm Shivaprasad G Bhat
2023-04-13 19:01 ` [PATCH 1/2] " Shivaprasad G Bhat
2023-05-02 9:03 ` Alex Bennée [this message]
2023-05-02 10:50 ` Richard Henderson
2023-05-02 14:02 ` Lucas Mateus Martins Araujo e Castro
2023-04-13 19:01 ` [PATCH 2/2] tests: tcg: ppc64: Add tests for Vector Extract Mask Instructions Shivaprasad G Bhat
2023-05-02 7:05 ` Cédric Le Goater
2023-05-04 5:17 ` Shivaprasad G Bhat
2023-05-02 15:05 ` Lucas Mateus Martins Araujo e Castro
2023-05-03 14:31 ` [PATCH 0/2] tcg: ppc64: Fix mask generation for vextractdm Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz3jt89i.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=john_platts@hotmail.com \
--cc=lucas.araujo@eldorado.org.br \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sbhat@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).