From: "Alex Bennée" <alex.bennee@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-devel@nongnu.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v2 2/4] cpus: Make {start,end}_exclusive() recursive
Date: Tue, 14 Feb 2023 09:26:46 +0000 [thread overview]
Message-ID: <87cz6cbns4.fsf@linaro.org> (raw)
In-Reply-To: <20230213125238.331881-3-iii@linux.ibm.com>
Ilya Leoshkevich <iii@linux.ibm.com> writes:
> Currently dying to one of the core_dump_signal()s deadlocks, because
> dump_core_and_abort() calls start_exclusive() two times: first via
> stop_all_tasks(), and then via preexit_cleanup() ->
> qemu_plugin_user_exit().
>
> There are a number of ways to solve this: resume after dumping core;
> check cpu_in_exclusive_context() in qemu_plugin_user_exit(); or make
> {start,end}_exclusive() recursive. Pick the last option, since it's
> the most straightforward one.
>
> Fixes: da91c1920242 ("linux-user: Clean up when exiting due to a signal")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-02-14 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 12:52 [PATCH v2 0/4] Fix deadlock when dying because of a signal Ilya Leoshkevich
2023-02-13 12:52 ` [PATCH v2 1/4] linux-user: Always exit from exclusive state in fork_end() Ilya Leoshkevich
2023-02-13 20:06 ` Richard Henderson
2023-02-14 9:26 ` Alex Bennée
2023-02-13 12:52 ` [PATCH v2 2/4] cpus: Make {start,end}_exclusive() recursive Ilya Leoshkevich
2023-02-13 20:12 ` Richard Henderson
2023-02-14 9:26 ` Alex Bennée [this message]
2023-02-13 12:52 ` [PATCH v2 3/4] linux-user/microblaze: Handle privileged exception Ilya Leoshkevich
2023-02-13 12:52 ` [PATCH v2 4/4] tests/tcg/linux-test: Add linux-fork-trap test Ilya Leoshkevich
2023-02-14 9:51 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz6cbns4.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=eduardo@habkost.net \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).