From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80F5AC433FE for ; Wed, 12 Oct 2022 12:23:09 +0000 (UTC) Received: from localhost ([::1]:46066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oialP-0000Y0-JA for qemu-devel@archiver.kernel.org; Wed, 12 Oct 2022 08:23:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiade-0001gj-W0 for qemu-devel@nongnu.org; Wed, 12 Oct 2022 08:15:14 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:44676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiadc-000705-VR for qemu-devel@nongnu.org; Wed, 12 Oct 2022 08:15:06 -0400 Received: by mail-wr1-x433.google.com with SMTP id r13so25926128wrj.11 for ; Wed, 12 Oct 2022 05:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=6w4zoXqAUPVCfkXE1CrVwSCJKJ7d7o+gtCXaocqFGHI=; b=Z4Iy9PuWf2XPLGVihbH1wNMM7QDmRjvnoy61MqDlxdRn/7CLcg+Kau9KVyIjhUnEA7 Ld/VXlPle7bsK+TEmMsTKEm32lkABjutmmCoD7Jeokrim+zeT6uYc3n6IBQOW0wuIENx 78wdLN5i42gEBiytJtICOY1snAGYjQGgjZW8zFBcVCzth5iQY0k/0cT3PXvFT80hYXWl 7g3jSHSr7N1VwFOvH3K1iiMc4sOk5ctt7OVwaQXsPGFB+oQFfi+Jbu4qwINcuDUITJJR MXetM1D4Qzo9zzE7XftC5l+CVn2z+4SKGGsB8imQlPA+yp4DrZA/H5diVNquzW8syuDy DoIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6w4zoXqAUPVCfkXE1CrVwSCJKJ7d7o+gtCXaocqFGHI=; b=xEkZgSt5kuz+VksYNLetTw7ACphr6r7RGYpprpi8i9Mz57omrdhwTf4zE8K49of9+T bVWjqOCwZNz43dRTDdu3wATW7RQ26W5KVhKmdfnI86TIP+GzLI3R2yuJSY/NjypYd6Ag ZKznpZI+MoBlqXnJ3Hw2hvb/9SjCj+DPiuG4/022UwbZmsC10b++BD4OMewk95rzMM6a uO4Nzl2lSGSu5+TwEuQKpnxvz90j/lOI65iBXqM3DDY1mlyOTnSLB5LGn0DfR/kFJNhQ 0DHMMfoGPwmut8quJrkUPwyUN+MtUvEMELm6Iunuv02TqqAhfe3j2uUsuqw4SLUhVLFC hcTA== X-Gm-Message-State: ACrzQf0ORm1hb7099Gx/3ar24SRWsEesrdNCAT+xb3Lfhxpt63Vofi7P hLsKu/lcR762SQZ4xdzRqBs35Q== X-Google-Smtp-Source: AMsMyM51qM5j6vecbYlbDYGqrLvAGk6SAoiE72cfiIubWgrPWdb/0a75f0nsVZNkE0lzdDHtmUWrrA== X-Received: by 2002:adf:e192:0:b0:232:3648:776d with SMTP id az18-20020adfe192000000b002323648776dmr1245471wrb.698.1665576903418; Wed, 12 Oct 2022 05:15:03 -0700 (PDT) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id z10-20020a05600c0a0a00b003a2f2bb72d5sm2443883wmp.45.2022.10.12.05.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 05:15:02 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1EFA21FFB7; Wed, 12 Oct 2022 13:15:02 +0100 (BST) References: <20221011192858.956078-1-alex.bennee@linaro.org> <20221011192858.956078-2-alex.bennee@linaro.org> <43330b01-01bb-e6db-1fb8-e737e1f92759@gmail.com> User-agent: mu4e 1.9.1; emacs 28.2.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Daniel Henrique Barboza Cc: Paolo Bonzini , qemu-devel , "Hajnoczi, Stefan" Subject: Re: [PULL 1/1] Revert "configure: build ROMs with container-based cross compilers" Date: Wed, 12 Oct 2022 13:13:51 +0100 In-reply-to: <43330b01-01bb-e6db-1fb8-e737e1f92759@gmail.com> Message-ID: <87czaxqlvd.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Daniel Henrique Barboza writes: > On 10/12/22 03:46, Paolo Bonzini wrote: >> Il mar 11 ott 2022, 21:29 Alex Benn=C3=A9e > > ha scritto: >> This reverts commit 730fe750fba63023e294ff0acf0f874369f1946f. >> Unconditionally building all the bios for all arches was a >> little too >> far too fast. >> I would like to understand the issue better, because chances are >> that it is preexisting and applies to the TCG tests as well. >> Daniel, does building the TCG tests work for you? If not, I think we >> should just disable containers by default. > > > 'make check-tcg' never worked in this particular Xeon host I use. I never > had the curiosity to find out why because I have access to a Power9 host > that runs 'make check-tcg'. > > Using this revert patch on top of master in this Xeon box makes 'make -j' > successful and 'make check-tcg' fails with the following error: > > > $ make -j > GIT ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 tests/fp/be= rkeley-softfloat-3 dtc > [1/24] Generating qemu-version.h with a custom command (wrapped by meson = to capture output) > > $ make check-tcg > GIT ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 tests/fp/be= rkeley-softfloat-3 dtc > BUILD debian-powerpc-test-cross > BUILD ppc64-linux-user guest-tests > Traceback (most recent call last): > File "/home/danielhb/qemu/tests/docker/docker.py", line 683, in > sys.exit(main()) > File "/home/danielhb/qemu/tests/docker/docker.py", line 679, in main > return args.cmdobj.run(args, argv) > File "/home/danielhb/qemu/tests/docker/docker.py", line 657, in run > return Docker().run(cmd, False, quiet=3Dargs.quiet, > File "/home/danielhb/qemu/tests/docker/docker.py", line 370, in run > ret =3D self._do_check(["run", "--rm", "--label", > File "/home/danielhb/qemu/tests/docker/docker.py", line 247, in _do_che= ck > return subprocess.check_call(self._command + cmd, **kwargs) > File "/usr/lib64/python3.9/subprocess.py", line 373, in check_call > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['podman', 'run', '--rm', '--labe= l', 'com.qemu.instance.uuid=3Dcf15761c98884d0a9b4e37f631ba593f', '--userns= =3Dkeep-id', '-u', '1005', '-w', '/home/danielhb/qemu/build/tests/tcg/ppc64= -linux-user', '-v', '/home/danielhb/qemu/build/tests/tcg/ppc64-linux-user:/= home/danielhb/qemu/build/tests/tcg/ppc64-linux-user:rw', '-v', '/home/danie= lhb/qemu:/home/danielhb/qemu:ro,z', 'qemu/debian-powerpc-test-cross', 'powe= rpc64-linux-gnu-gcc-10', '-Wall', '-Werror', '-O0', '-g', '-fno-strict-alia= sing', '-m64', '-mbig-endian', '/home/danielhb/qemu/tests/tcg/multiarch/flo= at_convd.c', '/home/danielhb/qemu/tests/tcg/multiarch/libs/float_helpers.c'= , '-o', 'float_convd', '-static', '-lm']' returned non-zero exit status 127. > filter=3D--filter=3Dlabel=3Dcom.qemu.instance.uuid=3Dcf15761c98884d0a9b4e= 37f631ba593f > make[1]: *** [/home/danielhb/qemu/tests/tcg/multiarch/Makefile.target:26:= float_convd] Error 1 > make: *** [/home/danielhb/qemu/tests/Makefile.include:50: build-tcg-tests= -ppc64-linux-user] Error 2 > > > This is very similar to the error message I get when running 'make -j' on= mainline > without this revert. > > So yeah, I guess we can say this is a preexisting condition that I always= saw with > 'make check-tcg' in this particular host, and 730fe750fba just made it ma= nifest when > running a plain 'make'. > > > Thanks, > > > Daniel > > >> Signed-off-by: Alex Benn=C3=A9e > > >> Cc: Paolo Bonzini > >> Reviewed-by: Daniel Henrique Barboza > >> Tested-by: Daniel Henrique Barboza > >> Message-Id: <20221011113417.794841-4-alex.bennee@linaro.org > >> diff --git a/configure b/configure >> index baa69189f0..45ee6f4eb3 100755 >> --- a/configure >> +++ b/configure >> @@ -2121,7 +2121,7 @@ probe_target_compiler() { >> =C2=A0 =C2=A0 =C2=A0target_ranlib=3D >> =C2=A0 =C2=A0 =C2=A0target_strip=3D >> =C2=A0 =C2=A0fi >> -=C2=A0 test -n "$target_cc" || test -n "$container_image" >> +=C2=A0 test -n "$target_cc" >> =C2=A0} >> =C2=A0write_target_makefile() { >> @@ -2268,7 +2268,7 @@ if test "$targetos" !=3D "darwin" && test "$ta= rgetos" !=3D "sunos" && \ >> =C2=A0 =C2=A0 =C2=A0config_mak=3Dpc-bios/optionrom/config.mak >> =C2=A0 =C2=A0 =C2=A0echo "# Automatically generated by configure - = do not modify" > $config_mak >> =C2=A0 =C2=A0 =C2=A0echo "TOPSRC_DIR=3D$source_path" >> $config_mak >> -=C2=A0 =C2=A0 write_target_makefile pc-bios/optionrom/all >> $confi= g_mak >> +=C2=A0 =C2=A0 write_target_makefile >> $config_mak >> =C2=A0fi >> =C2=A0if test "$softmmu" =3D yes && probe_target_compiler ppc-softm= mu; >> then >> @@ -2276,31 +2276,25 @@ if test "$softmmu" =3D yes && probe_target_c= ompiler ppc-softmmu; then >> =C2=A0 =C2=A0 =C2=A0config_mak=3Dpc-bios/vof/config.mak >> =C2=A0 =C2=A0 =C2=A0echo "# Automatically generated by configure - = do not modify" > $config_mak >> =C2=A0 =C2=A0 =C2=A0echo "SRC_DIR=3D$source_path/pc-bios/vof" >> $c= onfig_mak >> -=C2=A0 =C2=A0 write_target_makefile pc-bios/vof/all >> $config_mak >> +=C2=A0 =C2=A0 write_target_makefile >> $config_mak >> =C2=A0fi >> =C2=A0# Only build s390-ccw bios if the compiler has -march=3Dz900 = or >> -march=3Dz10 >> =C2=A0# (which is the lowest architecture level that Clang supports) >> =C2=A0if test "$softmmu" =3D yes && probe_target_compiler s390x-sof= tmmu; then >> -=C2=A0 got_cross_cc=3Dno >> -=C2=A0 if test -n "$target_cc"; then >> -=C2=A0 =C2=A0 write_c_skeleton >> -=C2=A0 =C2=A0 do_compiler "$target_cc" $target_cc_cflags -march=3Dz= 900 -o $TMPO -c $TMPC >> -=C2=A0 =C2=A0 has_z900=3D$? >> -=C2=A0 =C2=A0 if [ $has_z900 =3D 0 ] || do_compiler "$target_cc" $t= arget_cc_cflags -march=3Dz10 -msoft-float -Werror -o $TMPO -c $TMPC; then >> -=C2=A0 =C2=A0 =C2=A0 if [ $has_z900 !=3D 0 ]; then >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 echo "WARNING: Your compiler does not s= upport the z900!" >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 echo "=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0The s390-ccw bios will only work with guest CPUs >=3D z10." >> -=C2=A0 =C2=A0 =C2=A0 fi >> -=C2=A0 =C2=A0 =C2=A0 got_cross_cc=3Dyes >> +=C2=A0 write_c_skeleton >> +=C2=A0 do_compiler "$target_cc" $target_cc_cflags -march=3Dz900 -o = $TMPO -c $TMPC >> +=C2=A0 has_z900=3D$? >> +=C2=A0 if [ $has_z900 =3D 0 ] || do_compiler "$target_cc" $target_c= c_cflags -march=3Dz10 -msoft-float -Werror -o $TMPO -c $TMPC; then >> +=C2=A0 =C2=A0 if [ $has_z900 !=3D 0 ]; then >> +=C2=A0 =C2=A0 =C2=A0 echo "WARNING: Your compiler does not support = the z900!" >> +=C2=A0 =C2=A0 =C2=A0 echo "=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0The s3= 90-ccw bios will only work with guest CPUs >=3D z10." >> =C2=A0 =C2=A0 =C2=A0fi >> -=C2=A0 fi >> -=C2=A0 if test "$got_cross_cc" =3D yes || test -n "$container_image= "; then >> =C2=A0 =C2=A0 =C2=A0roms=3D"$roms pc-bios/s390-ccw" >> =C2=A0 =C2=A0 =C2=A0config_mak=3Dpc-bios/s390-ccw/config-host.mak >> =C2=A0 =C2=A0 =C2=A0echo "# Automatically generated by configure - = do not modify" > $config_mak >> =C2=A0 =C2=A0 =C2=A0echo "SRC_PATH=3D$source_path/pc-bios/s390-ccw"= >> $config_mak >> -=C2=A0 =C2=A0 write_target_makefile pc-bios/s390-ccw/all >> $config= _mak >> +=C2=A0 =C2=A0 write_target_makefile >> $config_mak >> =C2=A0 =C2=A0 =C2=A0# SLOF is required for building the s390-ccw fi= rmware on s390x, >> =C2=A0 =C2=A0 =C2=A0# since it is using the libnet code from SLOF f= or network booting. >> =C2=A0 =C2=A0 =C2=A0git_submodules=3D"${git_submodules} roms/SLOF" >> @@ -2488,7 +2482,7 @@ for target in $target_list; do >> =C2=A0 =C2=A0 =C2=A0 =C2=A0;; >> =C2=A0 =C2=A0esac >> -=C2=A0 if probe_target_compiler $target; then >> +=C2=A0 if probe_target_compiler $target || test -n "$container_imag= e"; then >> =C2=A0 =C2=A0 =C2=A0 =C2=A0test -n "$container_image" && build_stat= ic=3Dy >> =C2=A0 =C2=A0 =C2=A0 =C2=A0mkdir -p "tests/tcg/$target" >> =C2=A0 =C2=A0 =C2=A0 =C2=A0config_target_mak=3Dtests/tcg/$target/co= nfig-target.mak >> -- 2.34.1 >>=20 Can you check what ENGINE is in your config-host.mak? If no container engine is defined we should be gating against running docker. --=20 Alex Benn=C3=A9e