From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: peter.maydell@linaro.org, marcandre.lureau@gmail.com,
qemu-devel@nongnu.org, peterx@redhat.com, lsoaresp@redhat.com
Subject: Re: [PATCH v2 3/3] migration: Perform vmsd structure check during tests
Date: Wed, 02 Feb 2022 14:09:18 +0100 [thread overview]
Message-ID: <87czk5h0u9.fsf@secure.mitica> (raw)
In-Reply-To: <Yfprvld4Y/GoJbhh@work-vm> (David Alan Gilbert's message of "Wed, 2 Feb 2022 11:32:14 +0000")
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Juan Quintela (quintela@redhat.com) wrote:
>> "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
>> > * Juan Quintela (quintela@redhat.com) wrote:
>> >> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
>> >> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>> >> >
>> >> > Perform a check on vmsd structures during test runs in the hope
>> >> > of catching any missing terminators and other simple screwups.
>> >> >
>> >> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> >>
>> >> Reviewed-by: Juan Quintela <quintela@redhat.com>
>> >>
>> >> queued.
>> >
>> > Careful; I think that'll break with slirp until libslirp gets updated
>> > first.
>>
>> As expected, it broke it.
>>
>> I resend the PULL request wihtout that two patches.
>>
>> Once that we are here, how it is that make check didn't catch this?
>
> Because in my local world I did the changes to libslirp; I wanted to
> make sure qemu people were happy with the changes before proposing them
> to libslirp.
>
> Which I've just done:
>
> https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests/112
I mean make check.
It worked for me on my PULL request. I would have assumed that it
checks slirp.
Later, Juan.
next prev parent reply other threads:[~2022-02-02 13:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 19:44 [PATCH v2 0/3] vmsd checks Dr. David Alan Gilbert (git)
2022-01-13 19:44 ` [PATCH v2 1/3] ppc: Fix vmstate_pbr403 subsection name Dr. David Alan Gilbert (git)
2022-01-13 20:43 ` Peter Maydell
2022-01-17 9:53 ` Dr. David Alan Gilbert
2022-01-26 20:51 ` Juan Quintela
2022-01-13 19:44 ` [PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST Dr. David Alan Gilbert (git)
2022-01-13 20:41 ` Peter Maydell
2022-01-14 11:32 ` Philippe Mathieu-Daudé via
2022-01-14 15:35 ` Philippe Mathieu-Daudé via
2022-01-13 19:44 ` [PATCH v2 3/3] migration: Perform vmsd structure check during tests Dr. David Alan Gilbert (git)
2022-01-13 20:42 ` Peter Maydell
2022-01-26 20:53 ` Juan Quintela
2022-01-27 15:49 ` Dr. David Alan Gilbert
2022-01-31 9:00 ` Juan Quintela
2022-02-02 11:32 ` Dr. David Alan Gilbert
2022-02-02 13:09 ` Juan Quintela [this message]
2022-02-02 13:52 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czk5h0u9.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).