* [PATCH] docs: fix 'sample-pages' option tag
@ 2021-11-08 6:51 huangy81
2021-11-08 7:06 ` Markus Armbruster
2021-11-09 7:37 ` Juan Quintela
0 siblings, 2 replies; 3+ messages in thread
From: huangy81 @ 2021-11-08 6:51 UTC (permalink / raw)
To: qemu-devel
Cc: Markus Armbruster, Philippe Mathieu-Daudé,
Dr. David Alan Gilbert, Hyman Huang(黄勇),
Juan Quintela
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
commit f78d4ed701 has fixed qemu tag, making 'sample-pages' option tag
involved by accident, which introduced since 6.1 in commit 7afa08cd8fd.
revert this line.
Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
---
qapi/migration.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index f0aefda..bbfd48c 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1796,7 +1796,7 @@
# @calc-time: time in units of second for sample dirty pages
#
# @sample-pages: page count per GB for sample dirty pages
-# the default value is 512 (since 6.2)
+# the default value is 512 (since 6.1)
#
# @mode: mode containing method of calculate dirtyrate includes
# 'page-sampling' and 'dirty-ring' (Since 6.2)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: fix 'sample-pages' option tag
2021-11-08 6:51 [PATCH] docs: fix 'sample-pages' option tag huangy81
@ 2021-11-08 7:06 ` Markus Armbruster
2021-11-09 7:37 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2021-11-08 7:06 UTC (permalink / raw)
To: huangy81
Cc: Philippe Mathieu-Daudé, qemu-devel, Dr. David Alan Gilbert,
Juan Quintela
huangy81@chinatelecom.cn writes:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> commit f78d4ed701 has fixed qemu tag, making 'sample-pages' option tag
> involved by accident, which introduced since 6.1 in commit 7afa08cd8fd.
> revert this line.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
> qapi/migration.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index f0aefda..bbfd48c 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1796,7 +1796,7 @@
> # @calc-time: time in units of second for sample dirty pages
> #
> # @sample-pages: page count per GB for sample dirty pages
> -# the default value is 512 (since 6.2)
> +# the default value is 512 (since 6.1)
> #
> # @mode: mode containing method of calculate dirtyrate includes
> # 'page-sampling' and 'dirty-ring' (Since 6.2)
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: fix 'sample-pages' option tag
2021-11-08 6:51 [PATCH] docs: fix 'sample-pages' option tag huangy81
2021-11-08 7:06 ` Markus Armbruster
@ 2021-11-09 7:37 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Juan Quintela @ 2021-11-09 7:37 UTC (permalink / raw)
To: huangy81
Cc: Markus Armbruster, Philippe Mathieu-Daudé, qemu-devel,
Dr. David Alan Gilbert
huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> commit f78d4ed701 has fixed qemu tag, making 'sample-pages' option tag
> involved by accident, which introduced since 6.1 in commit 7afa08cd8fd.
> revert this line.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Queued.
Thanks, Juan.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-09 7:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-08 6:51 [PATCH] docs: fix 'sample-pages' option tag huangy81
2021-11-08 7:06 ` Markus Armbruster
2021-11-09 7:37 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).