From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A48AC4338F for ; Thu, 19 Aug 2021 11:28:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D0F76112D for ; Thu, 19 Aug 2021 11:28:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7D0F76112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGgDL-0002a0-Au for qemu-devel@archiver.kernel.org; Thu, 19 Aug 2021 07:28:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGgBo-0000tZ-5Z for qemu-devel@nongnu.org; Thu, 19 Aug 2021 07:26:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGgBk-00009l-WA for qemu-devel@nongnu.org; Thu, 19 Aug 2021 07:26:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629372381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=27MTJK/9v1dWgBqVggxJRRzy7bRk7/PVj1YgfTNF8iM=; b=BUv81tOGpAK28xyhXVVddaeFSv6ueZb5gxlARl4ZeFBoBfqP01LTivM2LCrTHQ+LkN428Z 0pwdTaQldrQaGzfiA09XjyRHBiKVfE2mdB9ZTGrTy9YO2hwHpakKW1zmI/IwcQKD3VWGMm GJRHt4V0CljyiQ0uflJQi078nWsoJY8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-601-V3iXttiNNJ-JC31mo4e5QA-1; Thu, 19 Aug 2021 07:26:18 -0400 X-MC-Unique: V3iXttiNNJ-JC31mo4e5QA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38C3A8799E0; Thu, 19 Aug 2021 11:26:16 +0000 (UTC) Received: from localhost (unknown [10.39.192.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7021F60916; Thu, 19 Aug 2021 11:26:10 +0000 (UTC) From: Cornelia Huck To: Yanan Wang , qemu-devel@nongnu.org Subject: Re: [PATCH v6 01/16] docs/about/removed-features: Remove duplicated doc about -smp In-Reply-To: <20210819031027.41104-2-wangyanan55@huawei.com> Organization: Red Hat GmbH References: <20210819031027.41104-1-wangyanan55@huawei.com> <20210819031027.41104-2-wangyanan55@huawei.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Thu, 19 Aug 2021 13:26:08 +0200 Message-ID: <87czq9smjz.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jones , =?utf-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Eduardo Habkost , Pierre Morel , "Michael S . Tsirkin" , Pankaj Gupta , Richard Henderson , Greg Kurz , Halil Pasic , wanghaibin.wang@huawei.com, Thomas Huth , Paolo Bonzini , Yanan Wang , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Aug 19 2021, Yanan Wang wrote: > There are two places describing the same thing about deprecation > of invalid topologies of -smp CLI, so remove the duplicated one. > > Signed-off-by: Yanan Wang > --- > docs/about/removed-features.rst | 21 ++++----------------- > 1 file changed, 4 insertions(+), 17 deletions(-) > > diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst > index cbfa1a8e31..f5d6e2ea9c 100644 > --- a/docs/about/removed-features.rst > +++ b/docs/about/removed-features.rst > @@ -194,7 +194,7 @@ by the ``tls-authz`` and ``sasl-authz`` options. > The ``pretty=on|off`` switch has no effect for HMP monitors and > its use is rejected. > > -``-drive file=json:{...{'driver':'file'}}`` (removed 6.0) > +``-drive file=json:{...{'driver':'file'}}`` (removed in 6.0) I would not change this in this patch; while the cleanup looks fine, there are some more instances and also e.g. things like x.y.z being used sometimes, and it's probably better to clean that up via a separated patch. > ''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > The 'file' driver for drives is no longer appropriate for character or host > @@ -593,7 +593,7 @@ error when ``-u`` is not used. > Command line options > -------------------- > > -``-smp`` (invalid topologies) (removed 5.2) > +``-smp`` (invalid topologies) (removed in 5.2) > ''''''''''''''''''''''''''''''''''''''''''' > > CPU topology properties should describe whole machine topology including > @@ -606,7 +606,7 @@ Support for invalid topologies is removed, the user must ensure > topologies described with -smp include all possible cpus, i.e. > *sockets* * *cores* * *threads* = *maxcpus*. > > -``-numa`` node (without memory specified) (removed 5.2) > +``-numa`` node (without memory specified) (removed in 5.2) > ''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > Splitting RAM by default between NUMA nodes had the same issues as ``mem`` > @@ -647,20 +647,7 @@ as ignored. Currently, users are responsible for making sure the backing storage > specified with ``-mem-path`` can actually provide the guest RAM configured with > ``-m`` and QEMU fails to start up if RAM allocation is unsuccessful. > > -``-smp`` (invalid topologies) (removed 5.2) > -''''''''''''''''''''''''''''''''''''''''''' > - > -CPU topology properties should describe whole machine topology including > -possible CPUs. > - > -However, historically it was possible to start QEMU with an incorrect topology > -where *n* <= *sockets* * *cores* * *threads* < *maxcpus*, > -which could lead to an incorrect topology enumeration by the guest. > -Support for invalid topologies is removed, the user must ensure > -topologies described with -smp include all possible cpus, i.e. > -*sockets* * *cores* * *threads* = *maxcpus*. Actually removing the duplicated section looks fine. > - > -``-machine enforce-config-section=on|off`` (removed 5.2) > +``-machine enforce-config-section=on|off`` (removed in 5.2) > '''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > The ``enforce-config-section`` property was replaced by the