From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v3 3/7] ui/vdagent: add mouse support
Date: Fri, 26 Mar 2021 15:59:11 +0100 [thread overview]
Message-ID: <87czvmhsg0.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20210326092448.367016-4-kraxel@redhat.com> (Gerd Hoffmann's message of "Fri, 26 Mar 2021 10:24:44 +0100")
Gerd Hoffmann <kraxel@redhat.com> writes:
> This patch adds support for mouse messages to the vdagent
> implementation. This can be enabled/disabled using the new
> 'mouse' parameter for the vdagent chardev. Default is on.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
[...]
> diff --git a/qapi/char.json b/qapi/char.json
> index 6e565ce42753..586ef2137368 100644
> --- a/qapi/char.json
> +++ b/qapi/char.json
> @@ -395,10 +395,12 @@
> #
> # Configuration info for vdagent.
> #
> +# @mouse: enable/disable mouse, default is enabled.
> +#
> # Since: 6.0
> ##
> { 'struct': 'ChardevVDAgent',
> - 'data': { },
> + 'data': { '*mouse' : 'bool' },
> 'base': 'ChardevCommon' }
>
> ##
Ah, now ChardevVDAgent isn't the same as ChardevCommon anymore.
Please format like
'data': { '*mouse': 'bool' },
for consistency with the rest of the file.
Acked-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2021-03-26 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 9:24 [PATCH v3 0/7] ui: add vdagent implementation and clipboard support Gerd Hoffmann
2021-03-26 9:24 ` [PATCH v3 1/7] ui: add clipboard infrastructure Gerd Hoffmann
2021-03-26 9:24 ` [PATCH v3 2/7] ui/vdagent: core infrastructure Gerd Hoffmann
2021-03-26 14:56 ` Markus Armbruster
2021-03-26 15:18 ` Eric Blake
2021-03-26 9:24 ` [PATCH v3 3/7] ui/vdagent: add mouse support Gerd Hoffmann
2021-03-26 14:59 ` Markus Armbruster [this message]
2021-03-26 9:24 ` [PATCH v3 4/7] ui/vdagent: add clipboard support Gerd Hoffmann
2021-03-26 9:24 ` [PATCH v3 5/7] ui/vnc: " Gerd Hoffmann
2021-03-26 9:24 ` [PATCH v3 6/7] ui/gtk: move struct GtkDisplayState to ui/gtk.h Gerd Hoffmann
2021-03-26 9:24 ` [PATCH v3 7/7] ui/gtk: add clipboard support Gerd Hoffmann
2021-03-26 9:39 ` [PATCH v3 0/7] ui: add vdagent implementation and " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czvmhsg0.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).