From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D4A2C2D0E4 for ; Thu, 19 Nov 2020 11:57:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40608246D1 for ; Thu, 19 Nov 2020 11:57:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kXDZEsgl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40608246D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfiZ2-0000hi-LS for qemu-devel@archiver.kernel.org; Thu, 19 Nov 2020 06:57:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfiXt-0007iC-Dp for qemu-devel@nongnu.org; Thu, 19 Nov 2020 06:56:13 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:40572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfiXq-0002z2-8k for qemu-devel@nongnu.org; Thu, 19 Nov 2020 06:56:12 -0500 Received: by mail-wm1-x341.google.com with SMTP id a3so6491696wmb.5 for ; Thu, 19 Nov 2020 03:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=6+mnefPYYUMtLLzAhCHln9YzYSJreVJtjI9cM4R9vCQ=; b=kXDZEsglo99gFPKEH2QkmDz6EAE4KjdlEoPDV2GuT2Qt/UWcHL4AYBYQF3re635zKi jhvdaaUWqEGyW3VCEWKrkPXDKnDV3vE/1HkKKXuobjoq8yiPZia832x/hEJF/6CacuiI lFZ7YBUYF5Mz+0S86FqSeajJAdwVplldDCJ4uW3sy9pFfJb15r0wBxIjlIxkg/iVGZjX 79JQyHGL3fJEnIsaFkoVm434R+AQqW+910m6TUgz76vP/6LFJJnmtUBqZL+1u6Pv3s7V 35WIt0k7yQ22eyFOh9LB5fJ27Sz6ivhHHjcL1UXQmV6LmJy7pqzsl9c5xnlkwHRQDSMz DnGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=6+mnefPYYUMtLLzAhCHln9YzYSJreVJtjI9cM4R9vCQ=; b=sMuKJpGQifI5MIHh+b4XGfq3Z/ZpBJVnIDMpJ+3gYPdIzj6fDKcmuYs5TxVCXjSZHZ MD4nSmYIUwL7Q4NC8fmtMteZ7AjKLbFQENAoqXsnXxWjJu2zs/Dcj5wNEV4qAQnlX+tG /iKRKJo8FSmYzOOSjLnjw8tqWiXDeuIDshMmCr/2zd2Y5TzcoigopHB7NgAWTgLKpGzg Gco5ncYxI6vk8PpGQqNnuFH19bfo5Wq17m00gY8oWareh6k6CR+XlwlpXEsIwjY/kbQa 6i5QML0xiFtT3enXwUfFJ58bPnKF/o9ZY+bM0pMlaiV/HMpXjAbFMie6x4icvTPS6/vd xllw== X-Gm-Message-State: AOAM532nHLnx69lCLsqGj7o8B/tRmMEMNgOjMj+YVGVcvbqQ2SeE8n/h uVN3r9r65fUO9Xgv0T+dExnW4Q== X-Google-Smtp-Source: ABdhPJwGhk92fqS7i78WknjwcTRkxto86Ej3nBeUTZd8FB4/Z2UNtW0BNrJH+GKLVIrMUaO1McrUNQ== X-Received: by 2002:a7b:c1d2:: with SMTP id a18mr4346467wmj.41.1605786968053; Thu, 19 Nov 2020 03:56:08 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id w1sm8825262wmi.24.2020.11.19.03.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 03:56:06 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1979E1FF7E; Thu, 19 Nov 2020 11:56:06 +0000 (GMT) References: <20201116104216.439650-1-david.edmondson@oracle.com> <20201116104216.439650-2-david.edmondson@oracle.com> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: David Edmondson Subject: Re: [RFC PATCH 1/5] hw/block: blk_check_size_and_read_all should report backend name In-reply-to: <20201116104216.439650-2-david.edmondson@oracle.com> Date: Thu, 19 Nov 2020 11:56:06 +0000 Message-ID: <87d009v9ux.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Max Reitz , Shannon Zhao , qemu-arm@nongnu.org, Igor Mammedov , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" David Edmondson writes: > If there are problems examining or reading data from the block > backend, the error messages should include an appropriate identifier > to assist in diagnoses. > > Signed-off-by: David Edmondson With Phillipe's suggested ''s: Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e