From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Sarah Harris <S.E.Harris@kent.ac.uk>,
Thomas Huth <huth@tuxfamily.org>,
Joaquin de Andres <me@xcancerberox.com.ar>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Michael Rolnik <mrolnik@gmail.com>
Subject: Re: [PATCH 1/3] target/avr: Drop tlb_flush() in avr_cpu_reset()
Date: Tue, 07 Jul 2020 09:27:14 +0100 [thread overview]
Message-ID: <87d057pw65.fsf@linaro.org> (raw)
In-Reply-To: <20200707064646.7603-2-f4bug@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset().
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/avr/cpu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/avr/cpu.c b/target/avr/cpu.c
> index 4e4dd4f6aa..50fb1c378b 100644
> --- a/target/avr/cpu.c
> +++ b/target/avr/cpu.c
> @@ -78,8 +78,6 @@ static void avr_cpu_reset(DeviceState *ds)
> env->skip = 0;
>
> memset(env->r, 0, sizeof(env->r));
> -
> - tlb_flush(cs);
> }
>
> static void avr_cpu_disas_set_info(CPUState *cpu, disassemble_info *info)
--
Alex Bennée
next prev parent reply other threads:[~2020-07-07 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 6:46 [PATCH 0/3] target/avr: Few fixes Philippe Mathieu-Daudé
2020-07-07 6:46 ` [PATCH 1/3] target/avr: Drop tlb_flush() in avr_cpu_reset() Philippe Mathieu-Daudé
2020-07-07 8:27 ` Alex Bennée [this message]
2020-07-07 6:46 ` [PATCH 2/3] target/avr: Fix $PC displayed address Philippe Mathieu-Daudé
2020-07-07 8:33 ` Alex Bennée
2020-07-07 6:46 ` [RFC PATCH 3/3] target/avr: Fix SBRC/SBRS instructions Philippe Mathieu-Daudé
2020-07-07 8:56 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d057pw65.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=S.E.Harris@kent.ac.uk \
--cc=f4bug@amsat.org \
--cc=huth@tuxfamily.org \
--cc=me@xcancerberox.com.ar \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).