From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "David Hildenbrand" <david@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v6 11/11] accel/tcg: Add stub for probe_access()
Date: Mon, 08 Jun 2020 12:08:40 +0100 [thread overview]
Message-ID: <87d0697r2f.fsf@linaro.org> (raw)
In-Reply-To: <20200605093256.30351-12-philmd@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> The TCG helpers where added in b92e5a22ec3 in softmmu_template.h.
> probe_write() was added in there in 3b4afc9e75a to be moved out
> to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored
> as probe_access() in c25c283df0f.
> Since it is a TCG specific helper, add a stub to avoid failures
> when building without TCG, such:
>
> target/arm/helper.o: In function `probe_read':
> include/exec/exec-all.h:362: undefined reference to `probe_access'
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
prev parent reply other threads:[~2020-06-08 11:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 9:32 [PATCH v6 00/11] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
2020-06-05 9:32 ` [PATCH v6 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-06-08 9:59 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-06-08 10:00 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-06-08 9:27 ` Wang, Wenchao
2020-06-08 15:25 ` Philippe Mathieu-Daudé
2020-06-05 9:32 ` [PATCH v6 04/11] rules.mak: Add strequal() and startwith() rules Philippe Mathieu-Daudé
2020-06-05 9:32 ` [PATCH v6 05/11] rules.mak: Add base-arch() rule Philippe Mathieu-Daudé
2020-06-08 10:10 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 06/11] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-06-08 10:10 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 07/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-06-08 10:13 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 08/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-06-08 10:13 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 09/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-06-08 10:15 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 10/11] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-06-08 11:09 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 11/11] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-06-08 11:08 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0697r2f.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=david@redhat.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).