From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2 3/6] Makefile: Restrict system emulation and tools objects
Date: Mon, 20 Jan 2020 11:03:39 +0000 [thread overview]
Message-ID: <87d0be4cfo.fsf@linaro.org> (raw)
In-Reply-To: <20200118140619.26333-4-philmd@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> Restrict all the system emulation and tools objects with a
> Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check.
>
> Using the same description over and over is not very helpful.
> Use it once, just before the if() block.
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> Makefile.objs | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 5aae561984..395dd1e670 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -4,16 +4,15 @@ stub-obj-y = stubs/
> util-obj-y = crypto/ util/ qobject/ qapi/
> qom-obj-y = qom/
>
> +#######################################################################
> +# code used by both qemu system emulation and qemu-img
> +
> +ifeq ($(call lor,$(CONFIG_SOFTMMU),$(CONFIG_TOOLS)),y)
> +
> chardev-obj-y = chardev/
>
> -#######################################################################
> -# authz-obj-y is code used by both qemu system emulation and qemu-img
> -
> authz-obj-y = authz/
>
> -#######################################################################
> -# block-obj-y is code used by both qemu system emulation and qemu-img
> -
> block-obj-y = nbd/
> block-obj-y += block.o blockjob.o job.o
> block-obj-y += block/ scsi/
> @@ -22,16 +21,12 @@ block-obj-$(CONFIG_REPLICATION) += replication.o
>
> block-obj-m = block/
>
> -#######################################################################
> -# crypto-obj-y is code used by both qemu system emulation and qemu-img
> -
> crypto-obj-y = crypto/
>
> -#######################################################################
> -# io-obj-y is code used by both qemu system emulation and qemu-img
> -
> io-obj-y = io/
>
> +endif # CONFIG_SOFTMMU or CONFIG_TOOLS
> +
> ######################################################################
> # Target independent part of system emulation. The long term path is to
> # suppress *all* target specific code in case of system emulation, i.e. a
--
Alex Bennée
next prev parent reply other threads:[~2020-01-20 11:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 14:06 [PATCH v2 0/6] buildsys: Build faster (mostly tools and linux-user) Philippe Mathieu-Daudé
2020-01-18 14:06 ` [PATCH v2 1/6] configure: Do not build libfdt if not required Philippe Mathieu-Daudé
2020-01-20 11:02 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 2/6] Makefile: Clarify all the codebase requires qom/ objects Philippe Mathieu-Daudé
2020-01-20 11:03 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 3/6] Makefile: Restrict system emulation and tools objects Philippe Mathieu-Daudé
2020-01-20 11:03 ` Alex Bennée [this message]
2020-01-18 14:06 ` [PATCH v2 4/6] Makefile: Remove unhelpful comment Philippe Mathieu-Daudé
2020-01-20 11:04 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 5/6] hw/core: Restrict reset handlers API to system-mode Philippe Mathieu-Daudé
2020-01-20 5:27 ` Thomas Huth
2020-01-20 11:07 ` Alex Bennée
2020-01-21 10:59 ` Philippe Mathieu-Daudé
2020-01-18 14:06 ` [PATCH v2 6/6] hw/core/Makefile: Group generic objects versus system-mode objects Philippe Mathieu-Daudé
2020-01-20 11:14 ` Alex Bennée
2020-01-18 14:22 ` [PATCH v2 0/6] buildsys: Build faster (mostly tools and linux-user) Philippe Mathieu-Daudé
2020-01-21 10:54 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0be4cfo.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).