qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: John Snow <jsnow@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option
Date: Tue, 17 Sep 2019 19:58:02 +0100	[thread overview]
Message-ID: <87d0fy21j9.fsf@linaro.org> (raw)
In-Reply-To: <20190917184948.24627-1-jsnow@redhat.com>


John Snow <jsnow@redhat.com> writes:

> It's not used; so remove the distraction.

It's a developer feature so you can run specific builds against the VM
images. I certainly have used it, unless you are saying it's broken now?

>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  tests/vm/Makefile.include | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
> index fea348e845..61758101fa 100644
> --- a/tests/vm/Makefile.include
> +++ b/tests/vm/Makefile.include
> @@ -28,7 +28,6 @@ vm-help vm-test:
>  	@echo
>  	@echo "Special variables:"
>  	@echo "    BUILD_TARGET=foo		 - Override the build target"
> -	@echo "    TARGET_LIST=a,b,c    	 - Override target list in builds"
>  	@echo '    EXTRA_CONFIGURE_OPTS="..."'
>  	@echo "    J=[0..9]*            	 - Override the -jN parameter for make commands"
>  	@echo "    DEBUG=1              	 - Enable verbose output on host and interactive debugging"
> @@ -65,7 +64,6 @@ vm-build-%: $(IMAGES_DIR)/%.img
>  		$(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
>  		--snapshot \
>  		--build-qemu $(SRC_PATH) -- \
> -		$(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
>  		$(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
>  		"  VM-BUILD $*")


--
Alex Bennée


  reply	other threads:[~2019-09-17 19:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 18:49 [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option John Snow
2019-09-17 18:58 ` Alex Bennée [this message]
2019-09-17 19:00   ` John Snow
2019-09-17 19:30     ` Alex Bennée
2019-09-17 19:52       ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0fy21j9.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).