From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glssz-0000x2-3Y for qemu-devel@nongnu.org; Tue, 22 Jan 2019 05:02:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glssw-0007G0-7B for qemu-devel@nongnu.org; Tue, 22 Jan 2019 05:02:24 -0500 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:58565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glssu-0007Ch-Uq for qemu-devel@nongnu.org; Tue, 22 Jan 2019 05:02:21 -0500 Date: Tue, 22 Jan 2019 19:02:11 +0900 Message-ID: <87d0opovrw.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato In-Reply-To: <937dc78e-beea-aa9c-ee35-e92023f74ad7@redhat.com> References: <20190121131602.55003-1-ysato@users.sourceforge.jp> <20190121131602.55003-2-ysato@users.sourceforge.jp> <937dc78e-beea-aa9c-ee35-e92023f74ad7@redhat.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH RFC 01/11] TCG translation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, Paolo Bonzini , Peter Crosthwaite , Richard Henderson On Mon, 21 Jan 2019 22:35:43 +0900, Thomas Huth wrote: > > On 2019-01-21 14:15, Yoshinori Sato wrote: > > This part only supported RXv1 instructions. > > Instruction manual. > > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf > > > > Signed-off-by: Yoshinori Sato > > --- > [...] > > diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c > > new file mode 100644 > > index 0000000000..c9c87dc308 > > --- /dev/null > > +++ b/target/rx/op_helper.c > > @@ -0,0 +1,548 @@ > > +/* > > + * RX helper functions > > + * > > + * Copyright (c) 2018 Yoshinori Sato > > + * > > + * This library is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License as published by the Free Software Foundation; either > > + * version 2 of the License, or (at your option) any later version. > > Hi, > > just a short meta comment for all the new files in your patch series: > It's either > > GNU *Library* General Public License, version 2 > > or > > GNU Lesser General Public License, version *2.1* > > I'd suggest to go with "Lesser" and "2.1". > > Apart from that, it might be a good idea to CC: some people who are > familiar with TCG if you want to make sure to get some review (see the > MAINTAINERS file for example). Thanks comment. OK. I will update the license text and resend it. > Thanks, > Thomas > > > PS: Seems like we've got this "Lesser" vs. "Library" wrong in a couple > of other source files in QEMU ... I'll try to come up with a patch to > fix this in the files that we've already got in the repo. > -- Yosinori Sato