qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules
@ 2018-06-22  2:15 Philippe Mathieu-Daudé
  2018-06-22  9:09 ` Alex Bennée
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-06-22  2:15 UTC (permalink / raw)
  To: Alex Bennée, Fam Zheng; +Cc: Philippe Mathieu-Daudé, qemu-devel

Builds only require:
- dtc
- keycodemapdb
- capstone

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Some tests might require ROMs. Can they clone submodules only when required?
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index fabfe9ec34..415d703c91 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -67,7 +67,7 @@ before_install:
   - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update ; fi
   - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew install libffi gettext glib pixman ; fi
   - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
-  - git submodule update --init --recursive
+  - git submodule update --init --recursive capstone dtc ui/keycodemapdb
 before_script:
   - ./configure ${CONFIG} || { cat config.log && exit 1; }
 script:
-- 
2.18.0.rc2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules
  2018-06-22  2:15 [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules Philippe Mathieu-Daudé
@ 2018-06-22  9:09 ` Alex Bennée
  2018-06-22  9:12 ` Peter Maydell
  2018-06-22 13:03 ` Alex Bennée
  2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2018-06-22  9:09 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé; +Cc: Fam Zheng, qemu-devel


Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Builds only require:
> - dtc
> - keycodemapdb
> - capstone
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Some tests might require ROMs. Can they clone submodules only when required?
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index fabfe9ec34..415d703c91 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -67,7 +67,7 @@ before_install:
>    - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update ; fi
>    - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew install libffi gettext glib pixman ; fi
>    - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
> -  - git submodule update --init --recursive
> +  - git submodule update --init --recursive capstone dtc
> ui/keycodemapdb

Does that mean we could drop the wget hack? That's there mainly because
cloning all the submodules takes some time.

>  before_script:
>    - ./configure ${CONFIG} || { cat config.log && exit 1; }
>  script:


--
Alex Bennée

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules
  2018-06-22  2:15 [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules Philippe Mathieu-Daudé
  2018-06-22  9:09 ` Alex Bennée
@ 2018-06-22  9:12 ` Peter Maydell
  2018-06-22 13:03 ` Alex Bennée
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2018-06-22  9:12 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé; +Cc: Alex Bennée, Fam Zheng, QEMU Developers

On 22 June 2018 at 03:15, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Builds only require:
> - dtc
> - keycodemapdb
> - capstone
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Some tests might require ROMs. Can they clone submodules only when required?

In general the ROM blobs should be in the main git repo; the submodules
are only the source for recompiling the blobs, I think.

thanks
-- PMM

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules
  2018-06-22  2:15 [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules Philippe Mathieu-Daudé
  2018-06-22  9:09 ` Alex Bennée
  2018-06-22  9:12 ` Peter Maydell
@ 2018-06-22 13:03 ` Alex Bennée
  2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2018-06-22 13:03 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé; +Cc: Fam Zheng, qemu-devel


Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Builds only require:
> - dtc
> - keycodemapdb
> - capstone
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Some tests might require ROMs. Can they clone submodules only when required?
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index fabfe9ec34..415d703c91 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -67,7 +67,7 @@ before_install:
>    - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update ; fi
>    - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew install libffi gettext glib pixman ; fi
>    - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
> -  - git submodule update --init --recursive
> +  - git submodule update --init --recursive capstone dtc
> ui/keycodemapdb

Queued with drop of wget as well. Thanks.

>  before_script:
>    - ./configure ${CONFIG} || { cat config.log && exit 1; }
>  script:


--
Alex Bennée

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-06-22 13:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-22  2:15 [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules Philippe Mathieu-Daudé
2018-06-22  9:09 ` Alex Bennée
2018-06-22  9:12 ` Peter Maydell
2018-06-22 13:03 ` Alex Bennée

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).